-
Notifications
You must be signed in to change notification settings - Fork 532
Some ANTs interfaces will be broken #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
and
are no longer available. |
An open pull request in Nov.14 has fixed the problem of |
I'll update #999 with the N4 bias correction change, and look into transformRigid. |
Thanks. @satra do you suggest anything for backward compatibility? Shall we add a new input, such as version, so that the final output command line will change. For example an input for ants version may work like this: antsRegistration.inputs.version = (a float) But I do not like this solution, because it will complicate the life of new users. The the other (smarter way) would be to use Python subprocess to quickly scan the help of ants binary each time and set the flags. |
👍 for the subprocess solution. Changing the flags is easy, adding robust logic to select the right one a little tricky. Unit testing that requires multiple ANTs versions ends up being hard, though, mainly thanks to Travis timeouts. Unfortunately I'm away right now and my laptop doesn't have ANTs built, so it's difficult for me to play with the parsing necessary. I didn't bother with backwards compatibility for the |
@armaneshaghi - there are a few things to consider.
so without having versions our only options might be to move some of these older interfaces to ants.legacy, but it will break some people's scripts. @armaneshaghi - would you be willing to start a conversation on the ants thread about versioning? that would actually be most helpful, as nipype has support for versions through the |
I close this as the issue will be resolved by regular ANTs releases. |
I know this is closed, but I just ran into this with ANTs and wanted to suggest an idea. The short CLI tag |
Great! I'll put in a PR |
I'm documenting changes I need to make for ANTs interfaces, as a new built has broken some Nipype interfaces. Unfortunately, ANTs versioning and its backward compatibility are not the best.
N4BiasFieldCorrection:
I think there are some changes we need to make for the registration interface, please add below as you find any broken interface.
The text was updated successfully, but these errors were encountered: