Skip to content

Commit 6f2f9cb

Browse files
committed
checking sys.version_info instead of TRAVIS_PYTHON_VERSION in the multiproc tests
1 parent b40ddaa commit 6f2f9cb

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

circle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ dependencies:
3535
test:
3636
override:
3737
- docker run -v /etc/localtime:/etc/localtime:ro -v ~/scratch:/scratch -w /root/src/nipype/doc nipype/nipype_test:py35 /usr/bin/run_builddocs.sh
38-
- docker run -v /etc/localtime:/etc/localtime:ro -e FSL_COURSE_DATA="/root/examples/nipype-fsl_course_data" -e TRAVIS_PYTHON_VERSION="3.5" -v ~/examples:/root/examples:ro -v ~/scratch:/scratch -w /root/src/nipype nipype/nipype_test:py35 /usr/bin/run_pytests.sh py35 :
38+
- docker run -v /etc/localtime:/etc/localtime:ro -e FSL_COURSE_DATA="/root/examples/nipype-fsl_course_data" -v ~/examples:/root/examples:ro -v ~/scratch:/scratch -w /root/src/nipype nipype/nipype_test:py35 /usr/bin/run_pytests.sh py35 :
3939
timeout: 2600
40-
- docker run -v /etc/localtime:/etc/localtime:ro -e FSL_COURSE_DATA="/root/examples/nipype-fsl_course_data" -e TRAVIS_PYTHON_VERSION="2.7" -v ~/examples:/root/examples:ro -v ~/scratch:/scratch -w /root/src/nipype nipype/nipype_test:py27 /usr/bin/run_pytests.sh py27 :
40+
- docker run -v /etc/localtime:/etc/localtime:ro -e FSL_COURSE_DATA="/root/examples/nipype-fsl_course_data" -v ~/examples:/root/examples:ro -v ~/scratch:/scratch -w /root/src/nipype nipype/nipype_test:py27 /usr/bin/run_pytests.sh py27 :
4141
timeout: 2600
4242
- docker run -v /etc/localtime:/etc/localtime:ro -v ~/examples:/root/examples:ro -v ~/scratch:/scratch -w /scratch nipype/nipype_test:py35 /usr/bin/run_examples.sh test_spm Linear /root/examples/ workflow3d :
4343
timeout: 1600

nipype/pipeline/plugins/tests/test_multiproc.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# -*- coding: utf-8 -*-
22
import logging
3-
import os
3+
import os, sys
44
from multiprocessing import cpu_count
55

66
import nipype.interfaces.base as nib
@@ -33,7 +33,7 @@ def _list_outputs(self):
3333
return outputs
3434

3535

36-
@pytest.mark.skipif(os.environ.get('TRAVIS_PYTHON_VERSION', '') == '2.7',
36+
@pytest.mark.skipif(sys.version_info < (3, 0),
3737
reason="Disabled until https://github.com/nipy/nipype/issues/1692 is resolved")
3838
def test_run_multiproc(tmpdir):
3939
os.chdir(str(tmpdir))
@@ -119,7 +119,7 @@ def find_metrics(nodes, last_node):
119119
return total_memory, total_threads
120120

121121

122-
@pytest.mark.skipif(os.environ.get('TRAVIS_PYTHON_VERSION') == '2.7',
122+
@pytest.mark.skipif(sys.version_info < (3, 0),
123123
reason="Disabled until https://github.com/nipy/nipype/issues/1692 is resolved")
124124
def test_no_more_memory_than_specified():
125125
LOG_FILENAME = 'callback.log'
@@ -180,7 +180,7 @@ def test_no_more_memory_than_specified():
180180
os.remove(LOG_FILENAME)
181181

182182

183-
@pytest.mark.skipif(os.environ.get('TRAVIS_PYTHON_VERSION', '') == '2.7',
183+
@pytest.mark.skipif(sys.version_info < (3, 0),
184184
reason="Disabled until https://github.com/nipy/nipype/issues/1692 is resolved")
185185
@pytest.mark.skipif(nib.runtime_profile == False, reason="runtime_profile=False")
186186
def test_no_more_threads_than_specified():

nipype/pipeline/plugins/tests/test_multiproc_nondaemon.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from builtins import range, open
88

99
# Import packages
10-
import os
10+
import os, sys
1111
from tempfile import mkdtemp
1212
from shutil import rmtree
1313
import pytest
@@ -90,7 +90,7 @@ def dummyFunction(filename):
9090
return total
9191

9292

93-
@pytest.mark.skipif(os.environ.get('TRAVIS_PYTHON_VERSION', '') == '2.7',
93+
@pytest.mark.skipif(sys.version_info < (3, 0),
9494
reason="Disabled until https://github.com/nipy/nipype/issues/1692 is resolved")
9595
def run_multiproc_nondaemon_with_flag(nondaemon_flag):
9696
'''
@@ -133,7 +133,7 @@ def run_multiproc_nondaemon_with_flag(nondaemon_flag):
133133
return result
134134

135135

136-
@pytest.mark.skipif(os.environ.get('TRAVIS_PYTHON_VERSION', '') == '2.7',
136+
@pytest.mark.skipif(sys.version_info < (3, 0),
137137
reason="Disabled until https://github.com/nipy/nipype/issues/1692 is resolved")
138138
def test_run_multiproc_nondaemon_false():
139139
'''
@@ -152,7 +152,7 @@ def test_run_multiproc_nondaemon_false():
152152
assert shouldHaveFailed
153153

154154

155-
@pytest.mark.skipif(os.environ.get('TRAVIS_PYTHON_VERSION', '') == '2.7',
155+
@pytest.mark.skipif(sys.version_info < (3, 0),
156156
reason="Disabled until https://github.com/nipy/nipype/issues/1692 is resolved")
157157
def test_run_multiproc_nondaemon_true():
158158
# with nondaemon_flag = True, the execution should succeed

0 commit comments

Comments
 (0)