TEST: Prefer vanilla unittest.skip* to pytest skips #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pytest #883 +/- ##
==========================================
- Coverage 91.36% 91.28% -0.08%
==========================================
Files 98 98
Lines 12166 12158 -8
Branches 2186 2185 -1
==========================================
- Hits 11115 11098 -17
- Misses 706 714 +8
- Partials 345 346 +1
Continue to review full report at Codecov.
|
effigies
force-pushed
the
test/vanilla_unittest
branch
from
e3bbf5b to
b35166f
Compare
effigies
force-pushed
the
test/vanilla_unittest
branch
from
b35166f to
a223c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both pytest and nose respect unittest marks, while nose doesn't respect pytest's. This strategy should reduce the need to add files to the ignore list in Travis as we finish up the conversion.
This is also hopefully more future-proof than nose. If pytest someday goes the same way as nose, then hopefully vanilla unittest structures will not need to be ported, reducing the burden.