Skip to content

TEST: test_tck and test_trk conversion to pytest #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

robbisg
Copy link
Collaborator

@robbisg robbisg commented Feb 4, 2020

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #874 into pytest will increase coverage by 2.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           pytest     #874      +/-   ##
==========================================
+ Coverage   81.33%   83.46%   +2.12%     
==========================================
  Files          97       97              
  Lines       12408    12427      +19     
  Branches     2187     2195       +8     
==========================================
+ Hits        10092    10372     +280     
+ Misses       1900     1686     -214     
+ Partials      416      369      -47     
Impacted Files Coverage Δ
nibabel/pydicom_compat.py 63.63% <0.00%> (-22.73%) ⬇️
nibabel/filename_parser.py 92.04% <0.00%> (-2.28%) ⬇️
nibabel/optpkg.py 93.10% <0.00%> (+3.35%) ⬆️
nibabel/streamlines/tractogram_file.py 100.00% <0.00%> (+5.00%) ⬆️
nibabel/streamlines/trk.py 94.62% <0.00%> (+16.45%) ⬆️
nibabel/streamlines/tck.py 99.46% <0.00%> (+19.78%) ⬆️
nibabel/streamlines/tractogram.py 99.67% <0.00%> (+24.75%) ⬆️
nibabel/streamlines/array_sequence.py 99.30% <0.00%> (+34.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2e0b8...3a2b0d1. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge if Travis passes.

@effigies
Copy link
Member

effigies commented Feb 4, 2020

Travis failed but not for reasons related to this PR. I'll go ahead and merge.

@effigies effigies merged commit 0011c11 into nipy:pytest Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants