TEST: pytest conversion #864 #865

[robbisg]

All tests passed on my laptop, and I'm waiting for Travis!
I kept the tests using np.assert_equal_array.

[codecov]

Codecov Report

Merging #870 into pytest will decrease coverage by 57.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           pytest     #870       +/-   ##
===========================================
- Coverage   81.59%   24.07%   -57.52%     
===========================================
  Files          97       97               
  Lines       12402    12155      -247     
  Branches     2186     2186               
===========================================
- Hits        10119     2926     -7193     
- Misses       1876     9149     +7273     
+ Partials      407       80      -327

Impacted Files	Coverage Δ
nibabel/rstutils.py	3.33% <0%> (-96.67%)	⬇️
nibabel/fileutils.py	9.09% <0%> (-90.91%)	⬇️
nibabel/nicom/utils.py	9.09% <0%> (-90.91%)	⬇️
nibabel/fileslice.py	8.87% <0%> (-88.4%)	⬇️
nibabel/orientations.py	12.29% <0%> (-87.71%)	⬇️
nibabel/freesurfer/io.py	9.33% <0%> (-84.89%)	⬇️
nibabel/cifti2/cifti2_axes.py	16.6% <0%> (-81.75%)	⬇️
nibabel/cmdline/diff.py	12.58% <0%> (-81.12%)	⬇️
nibabel/arraywriters.py	16.15% <0%> (-80.81%)	⬇️
nibabel/processing.py	21.33% <0%> (-78.67%)	⬇️
... and 69 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f908ca4...6d3155f. Read the comment docs.

[effigies]

Reviewed test_array_sequence.py

[effigies]

Tractogram comments.

[effigies]

Nice start! Apologies for the mass of suggestions.

[robbisg]

Nice start! Apologies for the mass of suggestions.

No worries!! I'm a mess I know!! ;)

[robbisg]

Done! 💪

[effigies]

I marked these modules to skip on the pytest branch. You might want to merge/rebase and then make sure the skips are being removed in the files you're touching.

[robbisg]

I can also do the test_tck.py and then rebase and merge, as you prefer!

[effigies]

I'd suggest rebasing or merging first. Then I can have another read through as you work on TCK.

[effigies]

Oh, sorry. I meant merge pytest into here... Ah well.

[robbisg]

Ops!