FIX: Read .PAR files corresponding to ADC maps #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
approved these changes
Oct 23, 2018
…vecs For example, post-processed ADC maps will be marked as diffusion scans but only have 3D data. The b-values and vectors from the original scan are not available in the header in this case.
…ion coefficient map
grlee77
force-pushed
the
parrec_adc_fix
branch
from
d89c850 to
d6310d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
+ Coverage 88.87% 88.88% +<.01%
==========================================
Files 93 93
Lines 11447 11449 +2
Branches 1891 1892 +1
==========================================
+ Hits 10174 10176 +2
Misses 933 933
Partials 340 340
Continue to review full report at Codecov.
|
effigies
changed the title
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, for any diffusion scan, the data will have multiple volumes (at least two b values must be acquired). However, it is possible to export ADC maps which seem to retain the same
general_infosection from the original scan's header, but actually only contain a single processed volume. This violates the assumptions that were made inget_bvals_bvecsand causesparrec2niito fail when converting .PAR/.REC data corresponding to ADC maps.This PR fixes this by returning (None, None) for
bvalsandbvecswhen there is only a single volume present in the file.A small (anonymous) .PAR header and test case have been included.