DOC: fix doctests for numpy 1.14 array printing. #591
Conversation
Numpy 1.14 has a different output format for the array. There's a bug in `numpy.set_printoptions(legacy='1.13')` so we can't use that to set the print format back to its previous output: numpy/numpy#10383 Depend on numpy 1.14 for the doctests.
matthew-brett
force-pushed
the
fix-doctests
branch
from
cc4b4f2 to
11818ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 177 177
Lines 24936 24936
Branches 2659 2659
=======================================
Hits 23556 23556
Misses 908 908
Partials 472 472Continue to review full report at Codecov.
|
|
Does it make sense to go ahead and update all the docstring tests, and get rid of the setup test function? Actually, it's not clear why those doctests aren't breaking, if legacy printing is buggy. |
|
I guess we didn't hit the particular case that exposes the bug. I'm easy either way for converting the doctests. Not converting means we can run the doctests on various versions, which does keep our test coverage up for versions of numpy < 1.14. Maybe we can convert if we hit this bug in the doctests at some point. |
|
Sounds good. +1 for merge. |
|
Thanks - I'll go ahead, so we've got all green on master again. |
Numpy 1.14 has a different output format for the array. There's a bug
in
numpy.set_printoptions(legacy='1.13')so we can't use that to setthe print format back to its previous output:
numpy/numpy#10383
Depend on numpy 1.14 for the doctests.