Skip to content

MRG: defer use of ufunc / memmap test until testing #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

matthew-brett
Copy link
Member

Avoid doing the ufunc / memmap test until we need it.

Might fix gh-571.

Avoid doing the ufunc / memmap test until we need it.

Might fix nipygh-571.
@satra
Copy link
Member

satra commented Oct 28, 2017

this lgtm.

@codecov-io
Copy link

codecov-io commented Oct 28, 2017

Codecov Report

Merging #572 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   94.32%   94.32%   +<.01%     
==========================================
  Files         177      177              
  Lines       24691    24695       +4     
  Branches     2638     2639       +1     
==========================================
+ Hits        23290    23294       +4     
  Misses        925      925              
  Partials      476      476
Impacted Files Coverage Δ
nibabel/testing/__init__.py 94.79% <100%> (ø) ⬆️
nibabel/testing/np_features.py 100% <100%> (ø) ⬆️
nibabel/tests/test_spatialimages.py 99.7% <100%> (ø) ⬆️
nibabel/tests/test_arrayproxy.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bf5e7...30f8ddd. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 96.254% when pulling 30f8ddd on matthew-brett:defer_viral_memmap into b1bf5e7 on nipy:master.

@effigies
Copy link
Member

LGTM, too. Anything you want to change before merging, @matthew-brett?

@matthew-brett
Copy link
Member Author

Nothing I want to change - go for it ...

@effigies effigies merged commit 2139ce0 into nipy:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nibabel 2.2.0 cannot be frozen
5 participants