Fix link to Wikipedia/Quaternion #525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 175 175
Lines 23890 23890
Branches 2568 2568
=======================================
Hits 22492 22492
Misses 918 918
Partials 480 480Continue to review full report at Codecov.
|
| @@ -263,7 +263,7 @@ The qform affine | |||
|
|
|||
| This affine can be calculated from a combination of the voxel sizes (entries 1 | |||
| through 4 of the ``pixdim`` field), a sign flip called ``qfac`` stored in | |||
| entry 0 of ``pixdim``, and a `quaternion <wikipedia quaternion>`_ that can be | |||
There was a problem hiding this comment.
Actually I think the correct fix is
`quaternion <wikipedia quaternion_>`_
which picks up the pre-defined link in the links_names.txt file...
|
Will push up a fix for this - thanks for pointing it out. Closing this one in favor of the fix above. |
matthew-brett
added a commit
that referenced
this pull request
Mar 31, 2017
Problem kindly pointed out by Fernando Pegar: #525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.