Clarified error messages in LazyTractogram #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 94.02% 94.05% +0.02%
==========================================
Files 166 166
Lines 21843 22047 +204
Branches 2325 2345 +20
==========================================
+ Hits 20538 20736 +198
- Misses 875 877 +2
- Partials 430 434 +4
Continue to review full report at Codecov.
|
nibabel/streamlines/tractogram.py
Outdated
| raise TypeError("`value` must be a generator function or None.") | ||
| if not callable(value): | ||
| msg = ("Values in a `LazyDict` must be generator functions." | ||
| " Those are functions which whenever are called return an" |
There was a problem hiding this comment.
Maybe "These are functions which, when called, return an instantiated generator."
There was a problem hiding this comment.
Thank for the suggestion, it is indeed way better.
| @@ -604,7 +607,10 @@ def _apply_affine(): | |||
|
|
|||
| def _set_streamlines(self, value): | |||
| if value is not None and not callable(value): | |||
| raise TypeError("`streamlines` must be a generator function.") | |||
| msg = ("`streamlines` must be a generator function. That is a" | |||
|
Completely forgot about this PR :O. |
|
@matthew-brett This PR should be good to go. I've modified some outputs messages as you suggested. |
|
Thanks - in it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies what "generator function" means in relevant error messages. It also makes sure all values contained in a
LazyDictobject are callable.