Skip to content

Format string {} not allowed in Python 2.6 #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

SyamGadde
Copy link
Contributor

pypi indicates that the current version of nibabel works for any version of Python, but the use of a literal '{}' (i.e. without indices) in a format string is only supported started in Python 2.7.

pypi indicates that the current version of nibabel works for any version of Python, but the use of a literal '{}' (i.e. without indices) in a format string is only supported started in Python 2.7.
@matthew-brett
Copy link
Member

Sorry - that's probably a bug in our specifications to pypi - we dropped Python 2.6 support for this last release.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.947% when pulling cdf1d28 on SyamGadde:patch-1 into ec4567f on nipy:master.

@codecov-io
Copy link

codecov-io commented Nov 10, 2016

Current coverage is 93.97% (diff: 100%)

Merging #496 into master will not change coverage

@@             master       #496   diff @@
==========================================
  Files           166        166          
  Lines         21836      21836          
  Methods           0          0          
  Messages          0          0          
  Branches       2327       2327          
==========================================
  Hits          20520      20520          
  Misses          885        885          
  Partials        431        431          

Powered by Codecov. Last update ec4567f...cdf1d28

@effigies
Copy link
Member

This was the only way I could see in pypi to indicate supported versions: aa4a727

@SyamGadde
Copy link
Contributor Author

Irrespective of nibabel's stated requirements, this change to the format string allows people who are stuck with Python 2.6 (RHEL/Centos 6) to at least use the portions of the library that work with Python 2.6. Nothing I've tried breaks quite yet.

@matthew-brett
Copy link
Member

Fair enough - in it goes. In general though, the point of dropping Python 2.6 testing and compatibility is so we can write code with the modern idioms, so expect to have more stuff break soon, and we can't guarantee the results are correct, with Python 2.6.

@matthew-brett matthew-brett merged commit 46ed742 into nipy:master Nov 11, 2016
@SyamGadde
Copy link
Contributor Author

Understood. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants