RF+TST: restore GiftiDataArray num_dim setter #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed the `GiftiDataArray.num_dim` attribute in favor of a property, but pymvpa was expecting to be able to set the value. Add a setter that raises a ValueError if the value is incorrect, and gives a deprecation warning regardless.
Current coverage is 94.23% (diff: 100%)@@ master #468 diff @@
==========================================
Files 160 160
Lines 21185 21197 +12
Methods 0 0
Messages 0 0
Branches 2265 2266 +1
==========================================
+ Hits 19961 19975 +14
+ Misses 803 802 -1
+ Partials 421 420 -1
|
|
Looks reasonable. If it fixes the PyMVPA tests, I'd say +1 for merge. |
|
Thank you! Meanwhile I will make it compatible with upcoming release. Will it be 2.0.3 or 2.1 or 3? ;) |
|
Next release will be 2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the
GiftiDataArray.num_dimattribute in favor of aproperty, but pymvpa was expecting to be able to set the value. Add a
setter that raises a ValueError if the value is incorrect, and gives a
deprecation warning regardless.