FIX: Copy affine_to_rasmm when slicing a Tractogram object #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -373,6 +374,13 @@ def test_tractogram_getitem(self): | |||
| DATA['tractogram'].data_per_streamline[::-1], | |||
| DATA['tractogram'].data_per_point[::-1]) | |||
|
|
|||
| # Make sure slicing conserve the affine_to_rasmm property. | |||
|
Other than tiny typo, looks good, thanks. |
Current coverage is 94.11%@@ master #462 diff @@
==========================================
Files 160 160
Lines 21164 21169 +5
Methods 0 0
Messages 0 0
Branches 2265 2265
==========================================
+ Hits 19919 19924 +5
Misses 823 823
Partials 422 422
|
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| def setup(): | |||
| global DATA | |||
| DATA['rng'] = np.random.RandomState(1234) | |||
There was a problem hiding this comment.
Is there a reason you're seeding with a constant?
There was a problem hiding this comment.
Unless nosetest sets the seed of np.random I prefer having reproducible tests. In practice, it should work with any seed, so there is no reason really. We also use a seed in test_array_sequence.py.
|
Anything else @effigies ? |
|
Oh, yeah. Sorry. LGTM. |
|
Thanks everyone for the input - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply makes sure to set the
affine_to_rasmmwhen creating a newTractogramobject that is the result of advanced indexing or slicing. It also adds a test to check it is working properly.