FIX: properly handle V4 .PAR files with diffusion info #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no 'diffusion' field will be present in image_defs, so use None for the bvecs The bvals can still be determined. A V4 .PAR file test case was created by truncating the fields of the existing V4.2 test case.
grlee77
changed the title
Merged
|
apologies... should have tested properly before uploading. I forgot that |
…in test_diffusion_parameters_v4.
|
Thanks - looks good to me. |
|
I can rebase to a single commit if you prefer. |
|
It's fine as is - was waiting to see if anyone else wanted to say something, but looks like no - merging. |
matthew-brett
added a commit
that referenced
this pull request
Mar 15, 2016
MRG: properly handle V4 .PAR files with diffusion info This PR fixes a bug in `get_bvals_bvecs` for V4 .PAR files (the bug is only present for V4, not the more recent V4.1 or V4.2). In V4, the `diffusion` field does not exist and the `bvecs` cannot be determined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
get_bvals_bvecsfor V4 .PAR files (the bug is only present for V4, not the more recent V4.1 or V4.2). In V4, thediffusionfield does not exist and thebvecscannot be determined.