MRG: testing on numpy 1.12 plus fixes #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add travis test run using per-commit numpy development wheel, to make sure numpy master isn't breaking anything for us.
Float indices becoming illegal in numpy 1.12. Also double ellipses.
matthew-brett
force-pushed
the
add-numpy-pre-testing
branch
2 times, most recently
from
ba5e69b to
c6582ca
Compare
|
This one also pretty straightforward - 5 minute review? |
|
LGTM. I only recently learned about the --pre flag to pip when we had an issue with an pip being outdated on our Appveyor builds in PyWavelets, but it looks like you already install a current version of pip in the scripts here and the tests are passing. |
|
Thanks for the review. |
matthew-brett
added a commit
that referenced
this pull request
Mar 16, 2016
MRG: testing on numpy 1.12 plus fixes Numpy 1.12 (not yet released) breaks some stuff; have travis test against daily numpy builds and fix problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 1.12 (not yet released) breaks some stuff; have travis test against daily
numpy builds and fix problems.