Skip to content

MRG: add Gregory Lee's new PARREC data #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

matthew-brett
Copy link
Member

Test parrec data with multiple rotations.

Modify translation order to minimize error between our rotations and
those from the NIfTI images in the conversion.

@matthew-brett matthew-brett mentioned this pull request Mar 11, 2016
@matthew-brett
Copy link
Member Author

The slight offset in the translations is still very puzzling to me.

I see that the amount that the afffine is off, depends on the rotations. Here is a print of the filename, the rotations in FH, AP, RL order, and the error in the translations:

T1W_cor_0_0_0_SENSE_13_1.PAR 0.0 0.0 0.0 [-0.0943233  -0.00043228 -0.0945    ]
T1W_cor_5_15_30_SENSE_12_1.PAR 5.0 15.0 30.0 [-0.08251608 -0.07266869 -0.07619181]
T1W_sag_0_0_0_SENSE_8_1.PAR 0.0 0.0 0.0 [ 0.00018147 -0.09492847 -0.0945    ]
T1W_sag_5_15_30_SENSE_11_1.PAR 5.0 15.0 30.0 [ 0.03278593 -0.1254854  -0.03404345]
T1W_trans_0_0_0_SENSE_4_1.PAR 0.0 0.0 0.0 [-0.0943233  -0.09492847  0.        ]
T1W_trans_5_15_30_SENSE_10_1.PAR 5.0 15.0 30.0 [-0.06638231 -0.10357589  0.05282434]

Has anyone got any ideas how to track this down?

@matthew-brett
Copy link
Member Author

Here's a script to investigate - https://gist.github.com/d251bd4f6c5aab653161 - nothing much came to me looking at the output.

@matthew-brett
Copy link
Member Author

Any thoughts on the incorrect translations? I can't think of anything to try.

@grlee77
Copy link
Contributor

grlee77 commented Mar 14, 2016

It is good to see that the rotations are a very close match now.

I played with it for awhile, but I couldn't get a better result for the translations either. The peak translation error across the test cases is about 0.3 voxels, which I could live with. Without access to the vendor's conversion code, it probably won't be easy to track down the source of the discrepancy.

Test parrec data with multiple rotations.

Modify translation order to minimize error between our rotations and
those from the NIfTI images in the conversion.
@matthew-brett
Copy link
Member Author

I'm surprised by the apparent order of the rotations - and it's very difficult to check visually with the one-slice images here.

@grlee77 - should you be bored one day in front of the scanner - would you consider taking some images with a fair few slices and three biggish rotations (maybe 15 20 25 degrees or something) so we can see visually if the rotations are right?

@matthew-brett matthew-brett changed the title WIP: add Gregory Lee's new PARREC data MRG: add Gregory Lee's new PARREC data Mar 16, 2016
@matthew-brett
Copy link
Member Author

I will merge this one soon unless I hear otherwise.

matthew-brett added a commit that referenced this pull request Mar 17, 2016
MRG: add Gregory Lee's new PARREC data

Test parrec data with multiple rotations.

Modify translation order to minimize error between our rotations and
those from the NIfTI images in the conversion.
@matthew-brett matthew-brett merged commit 15e16b4 into nipy:master Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants