MRG: fix for doctest errors on Python 3.5 #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand this deeply, but at a surface level LGTM. Should we enable Travis tests on Python 3.5 here to check that this solves Python 3.5 issues? |
|
Good idea for the tests. |
|
@matthew-brett got stuck at the installation phase: |
matthew-brett
force-pushed
the
py35-doctests
branch
2 times, most recently
from
e14e5bc to
5c88555
Compare
Make TripWireError subclass AttributeError. This prevents the Python 3.5 doctest machinery triggering a TripWireError when inspecting the module containing a TripWire instance during doctest initialization.
matthew-brett
force-pushed
the
py35-doctests
branch
from
ea30e47 to
7db7544
Compare
matthew-brett
added a commit
that referenced
this pull request
Oct 28, 2015
MRG: fix for doctest errors on Python 3.5 Fix doctest errors using TripWire on Python 3.5. Add Python 3.5 tests to travis run.
|
Thanks for the review - in it goes. |
This was referenced Nov 6, 2015
Closed
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: fix for doctest errors on Python 3.5 Fix doctest errors using TripWire on Python 3.5. Add Python 3.5 tests to travis run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.