increase sanity threshold for n_items per csa tag #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this - would you mind adding a test? |
|
Thanks for that. I submitted a PR will a few small changes. I noticed that when I increased the threshold for n_items, to try and read the 200n string, I got another error - is the 200n csa string valid? Are you sure there is no identifiable patient data in the csa files? |
|
The previous 200n csa string was not valid. It has been replaced with a valid one (it worked for me). Both new csastrings have absolutely no identifiable patient data. note: force pushed over 1 commit. |
Make error more explicit for too many items in the csa structure. Add module global for max items and test
|
Thanks for that. Consider also merging my PR to your branch? kevlarkevin#1 |
MRG: A little refactoring
|
Thanks for your PR. Much better test than what I had. |
matthew-brett
added a commit
that referenced
this pull request
Jul 30, 2014
MRG: increase sanity threshold for n_items per csa tag Allow more items in csa tags.
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
…rtion MRG: increase sanity threshold for n_items per csa tag Allow more items in csa tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request increases the sanity threshold for the number of items per CSA Header tag from 100 to 200. Some derived Siemens dicoms have CSA tags with more than 100 items.