Skip to content

Failing zstd tests #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
effigies opened this issue Feb 27, 2023 · 2 comments · Fixed by #1212
Closed

Failing zstd tests #1209

effigies opened this issue Feb 27, 2023 · 2 comments · Fixed by #1212
Labels

Comments

@effigies
Copy link
Member

The latest pyzstd release has changed the error type of:

>>> import io
>>> import pyzstd
>>> f = pyzstd.ZstdFile(io.BytesIO(b'bad'), mode='rb')
>>> f.read()

And tests are now failing.

@vanandrew Do you have time to look into this? I suspect what we want to do is coerce exceptions in Opener.read() to match expected exceptions from IOBase.read(), and possibly other methods.

@effigies effigies added the bug label Feb 27, 2023
@vanandrew
Copy link
Contributor

@effigies I'll add it to my to-do list, but I might not get around to it until late next month.

@effigies
Copy link
Member Author

No worries. I'll have a look at it in the next week or so if nobody gets there before me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants