-
Notifications
You must be signed in to change notification settings - Fork 301
[RTM] RF: Use N4BiasFieldCorrection(copy_header=True) #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -75,7 +75,7 @@ def _pick1st(inlist): | |||
magmrg = pe.Node(IntraModalMerge(), name='magmrg') | |||
|
|||
# de-gradient the fields ("bias/illumination artifact") | |||
n4 = pe.Node(ants.N4BiasFieldCorrection(dimension=3), name='n4') | |||
n4 = pe.Node(ants.N4BiasFieldCorrection(dimension=3, copy_header=True), name='n4') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this wasn't using init_n4bias_wf
already. If there's a good reason for not copying the header, let me know and I'll revert this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to merge when tests are green :)
This is failing a 4GB memory limit. (Memory usage) I'm not sure why this would newly be an issue. Could be the type of the bias-corrected image (which is now restored to that of the input T1w image). Should I re-run, or is there something obvious to fix up? |
This is very weird. Additionally, the process crashing is antsRegistration, not the bias correction. |
Let's try running first.
…On May 30, 2017 11:55 AM, "Chris Markiewicz" ***@***.***> wrote:
This is failing a 4GB memory limit. (Memory usage
<https://457-78558509-gh.circle-artifacts.com/0/tmp/memory-usage.txt>)
I'm not sure why this would newly be an issue. Could be the type of the
bias-corrected image (which is now restored to that of the input T1w
image). Should I re-run, or is there something obvious to fix up?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#542 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOkp6livY4wdpT7lfAKxTN9fFhLORe9ks5r_GYlgaJpZM4NqgCb>
.
|
Rerunning. Also, there's a workflow in niworkflows that should be updated along with this batch. Blocking merge for nipreps/niworkflows#173. |
That one worked. Updating pins and rebasing for a final test. |
820a079
to
05c1798
Compare
@@ -81,7 +81,7 @@ def init_anat_preproc_wf(skull_strip_ants, output_spaces, template, debug, frees | |||
RobustMNINormalizationRPT( | |||
generate_report=True, | |||
num_threads=omp_nthreads, | |||
testing=debug, | |||
flavor='testing' if debug else 'precise', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oesteban I believe this is the 0.0.7+ equivalent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Taking advantage of nipy/nipype#2034 to simplify workflows slightly.