Skip to content

[RTM] RF: Use N4BiasFieldCorrection(copy_header=True) #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2017

Conversation

effigies
Copy link
Member

Taking advantage of nipy/nipype#2034 to simplify workflows slightly.

@@ -75,7 +75,7 @@ def _pick1st(inlist):
magmrg = pe.Node(IntraModalMerge(), name='magmrg')

# de-gradient the fields ("bias/illumination artifact")
n4 = pe.Node(ants.N4BiasFieldCorrection(dimension=3), name='n4')
n4 = pe.Node(ants.N4BiasFieldCorrection(dimension=3, copy_header=True), name='n4')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this wasn't using init_n4bias_wf already. If there's a good reason for not copying the header, let me know and I'll revert this.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge when tests are green :)

@effigies
Copy link
Member Author

This is failing a 4GB memory limit. (Memory usage)

I'm not sure why this would newly be an issue. Could be the type of the bias-corrected image (which is now restored to that of the input T1w image). Should I re-run, or is there something obvious to fix up?

@oesteban
Copy link
Member

This is very weird. Additionally, the process crashing is antsRegistration, not the bias correction.

@chrisgorgo
Copy link
Contributor

chrisgorgo commented May 30, 2017 via email

@effigies effigies changed the title [RTM] RF: Use N4BiasFieldCorrection(copy_header=True) [WIP] RF: Use N4BiasFieldCorrection(copy_header=True) May 30, 2017
@effigies
Copy link
Member Author

Rerunning. Also, there's a workflow in niworkflows that should be updated along with this batch.

Blocking merge for nipreps/niworkflows#173.

@effigies
Copy link
Member Author

That one worked. Updating pins and rebasing for a final test.

@effigies effigies force-pushed the rf/n4bias_interface branch from 820a079 to 05c1798 Compare May 30, 2017 22:25
@effigies effigies changed the title [WIP] RF: Use N4BiasFieldCorrection(copy_header=True) [RTM] RF: Use N4BiasFieldCorrection(copy_header=True) May 30, 2017
@@ -81,7 +81,7 @@ def init_anat_preproc_wf(skull_strip_ants, output_spaces, template, debug, frees
RobustMNINormalizationRPT(
generate_report=True,
num_threads=omp_nthreads,
testing=debug,
flavor='testing' if debug else 'precise',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oesteban I believe this is the 0.0.7+ equivalent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@effigies effigies merged commit cdb83d1 into nipreps:master Jun 1, 2017
@effigies effigies deleted the rf/n4bias_interface branch June 1, 2017 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants