[WIP] Adding test for CachingHttpClient

Author: ktherage

src/Symfony/Component/HttpClient/Tests/CachingHttpClientTest.php

@@ -0,0 +1,129 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\HttpClient\Tests;
+
+use Psr\Log\LoggerInterface;
+use Symfony\Component\HttpClient\CachingHttpClient;
+use Symfony\Component\HttpClient\Exception\TransportException;
+use Symfony\Component\HttpClient\MockHttpClient;
+use Symfony\Component\HttpClient\NativeHttpClient;
+use Symfony\Component\HttpClient\Response\MockResponse;
+use Symfony\Component\HttpKernel\HttpCache\StoreInterface;
+use Symfony\Contracts\HttpClient\HttpClientInterface;
+use Symfony\Contracts\HttpClient\ResponseInterface;
+use Symfony\Contracts\HttpClient\Test\HttpClientTestCase;
+
+class TestCachingHttpClient extends CachingHttpClient
+{
+    protected $client;
+
+    public function __construct(StoreInterface $storeInterface, $testCase)
+    {
+        parent::__construct(new NativeHttpClient(), $storeInterface);
+
+        $headers = [
+            'Host: localhost:8057',
+            'Content-Type: application/json',
+        ];
+
+        $body = '{
+            "SERVER_PROTOCOL": "HTTP/1.1",
+            "SERVER_NAME": "127.0.0.1",
+            "REQUEST_URI": "/",
+            "REQUEST_METHOD": "GET",
+            "HTTP_FOO": "baR",
+            "HTTP_HOST": "localhost:8057"
+        }';
+
+        $this->client = new MockHttpClient(function (string $method, string $url, array $options) use ($headers, $body, $testCase) {
+
+            switch ($testCase) {
+                default:
+                    // force the request to be completed so that we don't test side effects of the transport
+                    $response = $this->request($method, $url, $options);
+                    $content = $response->getContent(false);
+
+                    return new MockResponse($content, $response->getInfo());
+
+                case 'testGetRequest':
+                    array_unshift($headers, 'HTTP/1.1 200 OK');
+
+                    if (preg_match('/length-broken$/', $url)){
+                        $headers = [
+                            'Host: localhost:8057',
+                            'Content-Length: 1000',
+                            'Content-Type: application/json',
+                        ];
+
+                        return new MockResponse($body, ['raw_headers' => $headers]);
+                    }
+
+                    return new MockResponse($body, ['raw_headers' => $headers]);
+//
+//                case 'testDnsError':
+//                    $mock = $this->getMockBuilder(ResponseInterface::class)->getMock();
+//                    $mock->expects($this->any())
+//                        ->method('getStatusCode')
+//                        ->willThrowException(new TransportException('DSN error'));
+//                    $mock->expects($this->any())
+//                        ->method('getInfo')
+//                        ->willReturn([]);
+//
+//                    $responses[] = $mock;
+//                    $responses[] = $mock;
+//                    break;
+//
+//                case 'testBadRequestBody':
+//                case 'testOnProgressCancel':
+//                case 'testOnProgressError':
+//                    $responses[] = new MockResponse($body, ['raw_headers' => $headers]);
+//                    break;
+//
+//                case 'testTimeoutOnAccess':
+//                    $mock = $this->getMockBuilder(ResponseInterface::class)->getMock();
+//                    $mock->expects($this->any())
+//                        ->method('getHeaders')
+//                        ->willThrowException(new TransportException('Timeout'));
+//
+//                    $responses[] = $mock;
+//                    break;
+//
+//                case 'testResolve':
+//                    $responses[] = new MockResponse($body, ['raw_headers' => $headers]);
+//                    $responses[] = new MockResponse($body, ['raw_headers' => $headers]);
+//                    $responses[] = $client->request('GET', 'http://symfony.com:8057/');
+//                    break;
+//
+//                case 'testTimeoutOnStream':
+//                case 'testUncheckedTimeoutThrows':
+//                    $body = ['<1>', '', '<2>'];
+//                    $responses[] = new MockResponse($body, ['raw_headers' => $headers]);
+//                    break;
+            }
+        });
+    }
+
+    public function request(string $method, string $url, array $options = []): ResponseInterface
+    {
+        return $this->client->request($method, $url, $options);
+    }
+}
+
+class CachingHttpClientTest extends HttpClientTestCase
+{
+    protected function getHttpClient(string $testCase): HttpClientInterface
+    {
+        $storeInterface = $this->createMock(StoreInterface::class);
+
+        return new TestCachingHttpClient($storeInterface, $testCase);
+    }
+}

src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php

@@ -48,6 +48,7 @@ public function testGetRequest()
         $info = $response->getInfo();
         $this->assertNull($info['error']);
         $this->assertSame(0, $info['redirect_count']);
+        $this->assertNotEmpty($info['raw_headers']);
         $this->assertSame('HTTP/1.1 200 OK', $info['raw_headers'][0]);
         $this->assertSame('Host: localhost:8057', $info['raw_headers'][1]);
         $this->assertSame('http://localhost:8057/', $info['url']);