Fix support for PHP 7.3

Author: nicolas-grekas

.travis.yml

@@ -22,11 +22,7 @@ env:
 
 matrix:
     include:
-        - php: 7.1
-        - php: 7.1
-          env: deps=high
-        - php: 7.2
-          env: deps=low
+        - php: nightly
 
     fast_finish: true
 
@@ -37,8 +33,6 @@ cache:
         - ~/php-ext
 
 services:
-    - memcached
-    - mongodb
     - redis-server
     - rabbitmq
 
@@ -129,31 +123,6 @@ before_install:
           echo opcache.enable_cli = 1 >> $INI
           echo apc.enable_cli = 1 >> $INI
           echo extension = redis.so >> $INI
-          echo extension = memcached.so >> $INI
-      done
-
-    - |
-      # Install extra PHP extensions
-      for PHP in $TRAVIS_PHP_VERSION $php_extra; do
-          export PHP=$PHP
-          phpenv global $PHP
-          INI=~/.phpenv/versions/$PHP/etc/conf.d/travis.ini
-
-          # Install librabbitmq
-          wget http://ftp.debian.org/debian/pool/main/libr/librabbitmq/librabbitmq-dev_0.5.2-2_amd64.deb
-          wget http://ftp.debian.org/debian/pool/main/libr/librabbitmq/librabbitmq1_0.5.2-2_amd64.deb
-          sudo dpkg -i librabbitmq1_0.5.2-2_amd64.deb librabbitmq-dev_0.5.2-2_amd64.deb
-
-          # install libsodium
-          sudo add-apt-repository ppa:ondrej/php -y
-          sudo apt-get update -q
-          sudo apt-get install libsodium-dev -y
-
-          tfold ext.apcu tpecl apcu-5.1.6 apcu.so $INI
-          tfold ext.libsodium tpecl libsodium sodium.so $INI
-          tfold ext.mongodb tpecl mongodb-1.5.0 mongodb.so $INI
-          tfold ext.amqp tpecl amqp-1.9.3 amqp.so $INI
-          tfold ext.igbinary tpecl igbinary-2.0.6 igbinary.so $INI
       done
 
     - |
@@ -215,7 +184,6 @@ install:
               break
           fi
           phpenv global $PHP
-          ([[ $deps ]] && cd src/Symfony/Component/HttpFoundation; composer require --dev --no-update mongodb/mongodb)
           tfold 'composer update' $COMPOSER_UP
           tfold 'phpunit install' ./phpunit install
           if [[ $deps = high ]]; then

src/Symfony/Component/BrowserKit/Client.php

@@ -665,11 +665,11 @@ protected function getAbsoluteUri($uri)
         }
 
         // anchor or query string parameters?
-        if (!$uri || '#' == $uri[0] || '?' == $uri[0]) {
+        if (0 === strcspn($uri, '#?')) {
             return preg_replace('/[#?].*?$/', '', $currentUri).$uri;
         }
 
-        if ('/' !== $uri[0]) {
+        if (0 !== strpos($uri, '/')) {
             $path = parse_url($currentUri, PHP_URL_PATH);
 
             if ('/' !== substr($path, -1)) {

src/Symfony/Component/Debug/Tests/phpt/decorate_exception_hander.phpt

@@ -1,5 +1,7 @@
 --TEST--
 Test catching fatal errors when handlers are nested
+--INI--
+display_errors=0
 --FILE--
 <?php
 
@@ -24,7 +26,6 @@ if (true) {
 
 ?>
 --EXPECTF--
-Fatal error: Class 'Symfony\Component\Debug\missing' not found in %s on line %d
 object(Symfony\Component\Debug\Exception\ClassNotFoundException)#%d (8) {
   ["message":protected]=>
   string(131) "Attempted to load class "missing" from namespace "Symfony\Component\Debug".

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php

@@ -170,6 +170,9 @@ public function testCookieOptions()
             'cookie_secure' => true,
             'cookie_httponly' => false,
         );
+        if (\PHP_VERSION_ID >= 70300) {
+            $options['cookie_samesite'] = '';
+        }
 
         $this->getStorage($options);
         $temp = session_get_cookie_params();

src/Symfony/Component/PropertyAccess/PropertyPath.php

@@ -116,7 +116,7 @@ public function __construct($propertyPath)
             throw new InvalidPropertyPathException(sprintf(
                 'Could not parse property path "%s". Unexpected token "%s" at position %d',
                 $propertyPath,
-                $remaining[0],
+                substr($remaining, 0, 1),
                 $position
             ));
         }