Add noUselessIndex to no-useless-path-segments #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
Found code that was mixing usages of index imports and directory imports.
For example with the following npm package file structure:
Some imports within the library would use
import './awesome';
while others usedimport './awesome/index';
.In es6 modules world those resolve to two different absolute paths, ie
C:/lib/src/awesome
vsC:/lib/src/awesome/index
so tooling that may not be aware of commonjs file resolution may treat them as different symbols. This is not a concern in modern versions of tooling that I have seen but enforcing the consistency seems useful anyway for readability.This PR copies the exisiting airbnb rule for import/no-useless-path-segments and adds the noUselessIndex configuration.