Update CI workflow

lucacome · lucacome · commit 54945969d253 · 2022-11-14T21:56:11.000-08:00
- Adds Quay.io
- Removes updated notification job, creates new notification workflow
- Adds Docker labels to CI
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,4 +1,4 @@
-name: Continuous Integration
+name: CI
 
 on:
   push:
@@ -30,28 +30,9 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-
-  vars:
-    name: Get variables
-    runs-on: ubuntu-20.04
-    outputs:
-      sha_short: ${{ steps.vars.outputs.sha }}
-      repo_name: ${{ steps.vars.outputs.repo }}
-      version: ${{ steps.vars.outputs.version }}
-    steps:
-      - name: Checkout Repository
-        uses: actions/checkout@v3
-      - name: Output Variables
-        id: vars
-        run: |
-          echo "::set-output name=sha::$(echo ${GITHUB_SHA} | cut -c1-7)"
-          echo "::set-output name=repo::$(echo ${GITHUB_REPOSITORY} | cut -d '/' -f 2)"
-          echo "::set-output name=version::$(echo ${GITHUB_REF} | cut -d '/' -f 2)"
-
   build:
     name: Build Image
     runs-on: ubuntu-20.04
-    needs: vars
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
@@ -70,37 +51,46 @@ jobs:
           username: ${{ github.repository_owner }}
           password: ${{ secrets.GITHUB_TOKEN }}
         if: github.event_name != 'pull_request'
+      - name: Login to Quay.io
+        uses: docker/login-action@v2
+        with:
+          registry: quay.io
+          username: ${{ secrets.QUAY_USERNAME }}
+          password: ${{ secrets.QUAY_ROBOT_TOKEN }}
+        if: github.event_name != 'pull_request'
       - name: Setup QEMU
         uses: docker/setup-qemu-action@v2
         with:
           platforms: arm64,ppc64le,s390x
         if: github.event_name != 'pull_request'
       - name: Docker Buildx
         uses: docker/setup-buildx-action@v2
+      - name: Output Variables
+        id: vars
+        run: |
+          echo "version=$(git describe --tags)" >> $GITHUB_OUTPUT
       - name: Docker meta
         id: meta
         uses: docker/metadata-action@v4
         with:
           images: |
             nginx/nginx-ingress-operator
             ghcr.io/nginxinc/nginx-ingress-operator
+            quay.io/nginx/nginx-ingress-operator
           tags: |
             type=edge
             type=ref,event=pr
             type=semver,pattern={{version}}
           labels: |
             org.opencontainers.image.documentation=https://docs.nginx.com/nginx-ingress-controller
             org.opencontainers.image.vendor=NGINX Inc <kubernetes@nginx.com>
-      - name: Output Variables
-        id: var
-        run: |
-          version=latest
-          if ${{ startsWith(github.ref, 'refs/tags/') }}; then
-              operator_version=v${{ needs.vars.outputs.version }}
-          else
-              operator_version=$version-${{ needs.vars.outputs.sha_short }}
-          fi
-          echo "::set-output name=version::$operator_version"
+            name="NGINX Ingress Operator"
+            maintainer="kubernetes@nginx.com"
+            vendor="NGINX Inc"
+            version=${{ steps.vars.outputs.version }}
+            release=1
+            summary="The NGINX Ingress Operator is a Kubernetes/OpenShift component which deploys and manages one or more NGINX/NGINX Plus Ingress Controllers"
+            description="The NGINX Ingress Operator is a Kubernetes/OpenShift component which deploys and manages one or more NGINX/NGINX Plus Ingress Controllers"
       - name: Build Image
         uses: docker/build-push-action@v3
         with:
@@ -112,9 +102,8 @@ jobs:
           platforms: ${{ github.event_name != 'pull_request' && env.platforms || '' }}
           load: ${{ github.event_name == 'pull_request' }}
           push: ${{ github.event_name != 'pull_request' }}
+          no-cache: ${{ github.event_name != 'pull_request' }}
           pull: true
-          build-args: |
-            VERSION=${{ steps.var.outputs.version }}
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@0.8.0
         continue-on-error: true
@@ -135,52 +124,3 @@ jobs:
           name: 'trivy-results.sarif'
           path: 'trivy-results.sarif'
         if: always()
-
-
-  notify:
-    name: Notify
-    runs-on: ubuntu-20.04
-    needs: [vars, build]
-    if: always() && github.ref == 'refs/heads/main'
-    steps:
-      - name: Workflow Status
-        id: check
-        uses: martialonline/workflow-status@v3
-      - name: Send Notification
-        uses: 8398a7/action-slack@v3
-        if: steps.check.outputs.status == 'failure'
-        with:
-          status: custom
-          custom_payload: |
-            {
-              username: 'Github',
-              icon_emoji: ':octocat:',
-              mention: 'channel',
-              attachments: [{
-                title: '${{ needs.vars.outputs.repo_name }} ${{ github.workflow }} pipeline has failed',
-                color: '${{ steps.check.outputs.status }}' == 'failure' ? 'danger' : 'warning',
-                fields: [{
-                  title: 'Commit Hash',
-                  value: '${{ needs.vars.outputs.sha_short }}',
-                  short: true
-                },
-                {
-                  title: 'Author',
-                  value: '${{ github.actor }}',
-                  short: true
-                },
-                {
-                  title: 'Commit Message',
-                  value: `${{ github.event.head_commit.message }}`,
-                  short: false
-                },
-                {
-                  title: 'Pipeline URL',
-                  value: 'https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}',
-                  short: false
-                }]
-              }]
-            }
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}
diff --git a/.github/workflows/notifications.yml b/.github/workflows/notifications.yml
@@ -0,0 +1,72 @@
+name: Notification
+
+on:
+  workflow_run:
+    branches: main
+    workflows:
+      - "CI"
+    types:
+      - completed
+
+jobs:
+  on-failure:
+    runs-on: ubuntu-20.04
+    if: ${{ github.event.workflow_run.conclusion == 'failure' && github.event.repository.fork == false }}
+    steps:
+      - name: Data
+        uses: actions/github-script@v6
+        continue-on-error: true
+        id: data
+        with:
+          script: |
+            const message = context.payload.workflow_run.head_commit.message
+            message_sanitized = message.split('\n')[0]
+
+            const check_data = (await github.rest.checks.listForRef({
+              owner: context.payload.repository.owner.login,
+              repo: context.payload.repository.name,
+              ref: context.payload.workflow_run.head_commit.id,
+            })).data.check_runs.filter(check_run => check_run.conclusion === 'failure')[0]
+
+            return {
+              job_name: check_data.name,
+              job_url: check_data.html_url,
+              commit_message: message_sanitized,
+            }
+
+      - name: Send Notification
+        uses: 8398a7/action-slack@v3
+        with:
+          status: custom
+          custom_payload: |
+            {
+              username: 'Github',
+              icon_emoji: ':github:',
+              mention: 'channel',
+              attachments: [{
+                title: '[${{ github.event.repository.full_name }}] ${{ github.event.workflow.name }} pipeline has failed (${{ github.event.workflow_run.event }})',
+                color: 'danger',
+                fields: [{
+                  title: 'Commit',
+                  value: `<https://github.com/${{ github.repository }}/commit/${{ github.event.workflow_run.head_commit.id }}|${{ fromJSON(steps.data.outputs.result).commit_message }}>`,
+                  short: true
+                },
+                {
+                  title: 'Failed Job',
+                  value: `<${{ fromJSON(steps.data.outputs.result).job_url }}|${{ fromJSON(steps.data.outputs.result).job_name }}>`,
+                  short: true
+                },
+                {
+                  title: 'Author',
+                  value: `${{ github.event.workflow_run.head_commit.author.name }}`,
+                  short: true
+                },
+                {
+                  title: 'Pipeline URL',
+                  value: `<https://github.com/${{ github.repository }}/actions/runs/${{ github.event.workflow_run.id }}|${{ github.event.workflow_run.id }}>`,
+                  short: true
+                }]
+              }]
+            }
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}
diff --git a/Dockerfile b/Dockerfile
@@ -1,22 +1,12 @@
 FROM quay.io/operator-framework/helm-operator:v1.25.1
 
-ARG VERSION
-
 ENV HOME=/opt/helm
 COPY watches.yaml ${HOME}/watches.yaml
 COPY helm-charts  ${HOME}/helm-charts
 WORKDIR ${HOME}
 
 COPY LICENSE /licenses/
 
-LABEL name="NGINX Ingress Operator" \
-      maintainer="kubernetes@nginx.com" \
-      vendor="NGINX Inc" \
-      version="v${VERSION}" \
-      release="1" \
-      summary="The NGINX Ingress Operator is a Kubernetes/OpenShift component which deploys and manages one or more NGINX/NGINX Plus Ingress Controllers" \
-      description="The NGINX Ingress Operator is a Kubernetes/OpenShift component which deploys and manages one or more NGINX/NGINX Plus Ingress Controllers"
-
 # hack to update packages with CVEs
 USER root
 RUN microdnf --nodocs upgrade -y libcom_err libxml2
