Apply PolicyAffected status for target refs #3535
Open
+543
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3535 +/- ##
==========================================
+ Coverage 86.82% 86.84% +0.02%
==========================================
Files 127 127
Lines 15079 15154 +75
Branches 62 62
==========================================
+ Hits 13092 13161 +69
- Misses 1836 1841 +5
- Partials 151 152 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
force-pushed
the
feat/policyAffected
branch
4 times, most recently
from
bed6023 to
fb9cf54
Compare
salonichf5
force-pushed
the
feat/policyAffected
branch
from
fb9cf54 to
e3bd76e
Compare
|
@salonichf5 I see in the issue |
bjee19
reviewed
Jun 25, 2025
Comment on lines
+492
to
+494
| if conditionsList == nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
do we have to worry about this case? Will the conditionsList ever be nil?
ciarams87
reviewed
Jun 25, 2025
| @@ -185,6 +197,33 @@ func ConvertConditions( | |||
| return apiConds | |||
| } | |||
|
|
|||
| // HasMatchingCondition checks if the given condition matches any of the existing conditions. | |||
| func HasMatchingCondition(existingConditions []Condition, cond Condition) bool { | |||
| condMap := make(map[Condition]struct{}, len(existingConditions)) | |||
There was a problem hiding this comment.
Because existingConditions is unlikely to be very long, do we think this could be updated to use a simple iteration instead? e.g. something like
for _, existing := range existingConditions {
if existing.Type == cond.Type &&
existing.Status == cond.Status &&
existing.Reason == cond.Reason &&
existing.Message == cond.Message {
return true
}
}
return false
| @@ -105,3 +105,43 @@ func TestConvertConditions(t *testing.T) { | |||
| result := ConvertConditions(conds, generation, time) | |||
| g.Expect(result).Should(Equal(expected)) | |||
| } | |||
|
|
|||
| func TestHasMatchingConding(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| func TestHasMatchingConding(t *testing.T) { | |
| func TestHasMatchingCondition(t *testing.T) { |
| @@ -448,3 +448,60 @@ func refGroupKind(group v1.Group, kind v1.Kind) string { | |||
|
|
|||
| return fmt.Sprintf("%s/%s", group, kind) | |||
| } | |||
|
|
|||
| // addPolicyAffectedStatusToTargetRefs adds the policyAffected status to the target references | |||
| // of ClientSetttingsPolicies and ObservabilityPolicies. | |||
There was a problem hiding this comment.
Suggested change
| // of ClientSetttingsPolicies and ObservabilityPolicies. | |
| // of ClientSettingsPolicies and ObservabilityPolicies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: As a user I would like to know which target refs are affected by ClientSettingsPolicy or ObservabilityPolicy
Solution: Adds new conditions
NewObservabilityPolicyAffectedandNewClientSettingsPolicyAffectedTesting: Manual testing
Apply
ObservabilityPolicyandClientSettingsPolicytotargetRefstargetRefsconditions list.targetRefsconditions list -- Status is removed from the resources (Gateways, HTTPRoute, GRPCRoute)ClientSettingsPolicy for Gateway, HTTPRoutes and GRPCRoutes
policyAffectedwas removed from the resources.ObservabilityPolicy for HTTPRoutes and GRPCRoutes
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1761
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.