Only write images to cache from the Build job #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
force-pushed
the
chore/build-cache
branch
5 times, most recently
from
3261b70 to
f923b14
Compare
Problem: There are multiple workflows and jobs all writing to the same cache causing it to be invalidated Solution: Write to cache only in the Build job and read the cache from all the other jobs.
lucacome
force-pushed
the
chore/build-cache
branch
from
f923b14 to
38f9af8
Compare
sjberman
reviewed
Mar 15, 2024
|
We'll have to update the required checks at the repo level to the new jobs. |
sjberman
reviewed
Mar 15, 2024
sjberman
reviewed
Mar 15, 2024
lucacome
force-pushed
the
chore/build-cache
branch
from
2c7b05c to
880b0a6
Compare
sjberman
approved these changes
Mar 15, 2024
kate-osborn
approved these changes
Mar 15, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: There are multiple workflows and jobs all writing to the same cache causing it to be invalidated Solution: Write to cache only in the Build job and read the cache from all the other jobs.
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: There are multiple workflows and jobs all writing to the same cache causing it to be invalidated Solution: Write to cache only in the Build job and read the cache from all the other jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: There are multiple workflows and jobs all writing to the same
cache causing it to be invalidated
Solution: Write to cache only in the Build job and read the cache from
all the other jobs.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.