Validate Data Plane resources name length

[baburciu]

In

nginx-gateway-fabric/internal/framework/controller/resource.go

Lines 11 to 15 in c775781

	// CreateNginxResourceName creates the base resource name for all nginx resources
	// created by the control plane.
	func CreateNginxResourceName(prefix, suffix string) string {
	return fmt.Sprintf("%s-%s", prefix, suffix)
	}

it should probably be useful if we validate against RFC 1123 DNS Label standard, as all NGF Data Plane resources (Service, Deployment, Secrets, ConfigMap, ServiceAccount) use a name formed out of <GatewayClass name>-<Gateway name>, which for Services is limited to 63 characters.

$ k get-all | grep gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev
configmap/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-agent-config                                                                                                               dev                 147m
configmap/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-includes-bootstrap                                                                                                         dev                 147m
serviceaccount/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev                                                                                                                       dev                 147m
deployment.apps/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev                                                                                                                      dev                 147m
replicaset.apps/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-55bd657779                                                                                                           dev                 147m
replicaset.apps/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-56699488c7                                                                                                           dev                 101m
replicaset.apps/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-68c5fc6d96                                                                                                           dev                 101m
pod/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-68c5fc6db9fbw                                                                                                                    dev                 101m
service/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev                                                                                                                              dev                 147m
secret/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-ngf-agent-tls                                                                                                                 dev                 101m
endpoints/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev                                                                                                                            dev                 147m
endpointslice.discovery.k8s.io/gw-ingress-dev-nonprodtotocorpnetwork-ngf-npn-dev-xkx6h                                                                                                 dev                 147m

With an unfortunate choice of Gateway name and GatewayClass, the Control Plane could result in errors like:

{"level":"error","ts":"2025-10-22T13:49:17Z","logger":"eventHandler","msg":"error getting Gateway Service IP address","error":"error finding Service gw-ingress-dev-nonprodtotocorpnetwork-ngf-nonprodtotocorpnetwork-dev for Gateway: context deadline exceeded","stacktrace":"github.com/nginx/nginx-gateway-fabric/v2/internal/controller.(*eventHandlerImpl).updateStatuses\n\t/home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/internal/controller/handler.go:333\ngithub.com/nginx/nginx-gateway-fabric/v2/internal/controller.(*eventHandlerImpl).waitForStatusUpdates\n\t/home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/internal/controller/handler.go:280"}

$ kubectl create service clusterip gw-ingress-dev-nonprodtotocorpnetwork-ngf-nonprodtotocorpnetwork-dev --tcp=80:8080
error: failed to create ClusterIP service: Service "gw-ingress-dev-nonprodtotocorpnetwork-ngf-nonprodtotocorpnetwork-dev" is invalid: [metadata.name: Invalid value: "gw-ingress-dev-nonprodtotocorpnetwork-ngf-nonprodtotocorpnetwork-dev": must be no more than 63 characters, metadata.labels: Invalid value: "gw-ingress-dev-nonprodtotocorpnetwork-ngf-nonprodtotocorpnetwork-dev": must be no more than 63 characters, spec.selector: Invalid value: "gw-ingress-dev-nonprodtotocorpnetwork-ngf-nonprodtotocorpnetwork-dev": must be no more than 63 characters]

[salonichf5]

Good catch, thanks for bringing this up! Validating against the RFC 1123 DNS label standard sounds reasonable given how NGF constructs Data Plane resource names. We should ensure this constraint is enforced to avoid name length issues.

We have a story tracking the issue.