Skip to content

Commit 628f408

Browse files
committed
Have renovate manage the versions of goimports and gofumpt
1 parent 629e5da commit 628f408

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

Makefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ GOOS ?= linux ## The OS of the binary. For example linu
2424
TELEMETRY_ENDPOINT ?= oss.edge.df.f5.com:443
2525
# renovate: datasource=docker depName=golangci/golangci-lint
2626
GOLANGCI_LINT_VERSION ?= v2.6.2 ## The version of golangci-lint to use
27+
# renovate: datasource=go depName=golang.org/x/tools
28+
GOIMPORTS_VERSION ?= v0.38.0 ## The version of goimports to use
29+
# renovate: datasource=go depName=mvdan.cc/gofumpt
30+
GOFUMPT_VERSION ?= v0.4.0 ## The version of gofumpt to use
2731

2832
# Additional flags added here can be accessed in main.go.
2933
# e.g. `main.version` maps to `var version` in main.go
@@ -68,10 +72,10 @@ lint-python: ## Run linter for python tests
6872

6973
.PHONY: format
7074
format: ## Run goimports & gofmt
71-
@go install golang.org/x/tools/cmd/goimports
72-
@go install mvdan.cc/gofumpt@latest
73-
@goimports -l -w .
74-
@gofumpt -l -w .
75+
go install golang.org/x/tools/cmd/goimports@$(GOIMPORTS_VERSION)
76+
go install mvdan.cc/gofumpt@$(GOFUMPT_VERSION)
77+
goimports -l -w .
78+
gofumpt -l -w .
7579

7680
.PHONY: staticcheck
7781
staticcheck: ## Run staticcheck linter

go.mod

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ require (
2121
github.com/stretchr/testify v1.11.1
2222
go.opentelemetry.io/otel v1.38.0
2323
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.38.0
24-
golang.org/x/tools v0.38.0
2524
k8s.io/api v0.34.2
2625
k8s.io/apiextensions-apiserver v0.34.2
2726
k8s.io/apimachinery v0.34.2
@@ -184,10 +183,10 @@ require (
184183
golang.org/x/oauth2 v0.31.0 // indirect
185184
golang.org/x/sync v0.18.0 // indirect
186185
golang.org/x/sys v0.38.0 // indirect
187-
golang.org/x/telemetry v0.0.0-20251008203120-078029d740a8 // indirect
188186
golang.org/x/term v0.37.0 // indirect
189187
golang.org/x/text v0.31.0 // indirect
190188
golang.org/x/time v0.13.0 // indirect
189+
golang.org/x/tools v0.38.0 // indirect
191190
google.golang.org/genproto/googleapis/api v0.0.0-20250825161204-c5933d9347a5 // indirect
192191
google.golang.org/genproto/googleapis/rpc v0.0.0-20250929231259-57b25ae835d4 // indirect
193192
google.golang.org/grpc v1.75.1 // indirect

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,8 +489,6 @@ golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBc
489489
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
490490
golang.org/x/sys v0.38.0 h1:3yZWxaJjBmCWXqhN1qh02AkOnCQ1poK6oF+a7xWL6Gc=
491491
golang.org/x/sys v0.38.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
492-
golang.org/x/telemetry v0.0.0-20251008203120-078029d740a8 h1:LvzTn0GQhWuvKH/kVRS3R3bVAsdQWI7hvfLHGgh9+lU=
493-
golang.org/x/telemetry v0.0.0-20251008203120-078029d740a8/go.mod h1:Pi4ztBfryZoJEkyFTI5/Ocsu2jXyDr6iSdgJiYE/uwE=
494492
golang.org/x/term v0.37.0 h1:8EGAD0qCmHYZg6J17DvsMy9/wJ7/D/4pV/wfnld5lTU=
495493
golang.org/x/term v0.37.0/go.mod h1:5pB4lxRNYYVZuTLmy8oR2BH8dflOR+IbTYFD8fi3254=
496494
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

tools.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
package tools
88

99
import (
10-
_ "golang.org/x/tools/cmd/goimports"
1110
_ "k8s.io/code-generator"
1211
_ "sigs.k8s.io/controller-tools/cmd/controller-gen"
1312
)

0 commit comments

Comments
 (0)