Skip to content

Commit 2b6aa76

Browse files
authored
Specify runAsNonRoot in daemon-set manifests (#3925)
This is a no-op change. It aligns the `daemon-set` manifests to match the `deployment` manifests. Both of these currently specify an explicit user ID to run as, therefore the container is guaranteed to be run as non-root. This `runAsNonRoot: true` instruction would come in as important if the chart no longer specifies `runAsUser`, and someone is packaging their own image without a USER directive in the Dockerfile. Removing the `runAsUser` parameter could be useful as to allow OpenShift to override the UID, in a later change.
1 parent a580c91 commit 2b6aa76

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

deployments/daemon-set/nginx-ingress.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ spec:
6363
allowPrivilegeEscalation: false
6464
# readOnlyRootFilesystem: true
6565
runAsUser: 101 #nginx
66+
runAsNonRoot: true
6667
capabilities:
6768
drop:
6869
- ALL

deployments/daemon-set/nginx-plus-ingress.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ spec:
6363
allowPrivilegeEscalation: false
6464
# readOnlyRootFilesystem: true
6565
runAsUser: 101 #nginx
66+
runAsNonRoot: true
6667
capabilities:
6768
drop:
6869
- ALL

0 commit comments

Comments
 (0)