Skip to content

enhancement: Move legal notice to an appropriate location #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented May 30, 2025

Proposed changes

From issue #625

'I wonder if we can tuck the legal blurb at the bottom of this doc somewhere else -- it's a bit awkward to lead with it.

Right now it reads like:
“Here are the great things you can do with NGINX One. But first, a word from the lawyers.”'

Solution: Moved content to the bottom of the glossary

Closes #625

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang self-assigned this May 30, 2025
@mjang mjang requested a review from a team as a code owner May 30, 2025 14:53
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels May 30, 2025
@mjang mjang added enhancement New feature or request and removed documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels May 30, 2025
@mjang mjang requested a review from travisamartin May 30, 2025 14:54
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/633/

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels May 30, 2025
@mjang mjang merged commit fd036da into main May 30, 2025
8 checks passed
@mjang mjang deleted the move-legal-notice branch May 30, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: move legal blurb
3 participants