-
Notifications
You must be signed in to change notification settings - Fork 83
Updated guide to use NGINX/NGINX Plus as the Ingress Controller in EKS #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Hi @madebydna , you've done a great amount of work on this. I look forward to reviewing it, hopefully in the next couple of days (or at least by the end of the week). |
Thanks @mjang! It was a fun challenge. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @madebydna! I'm the assigned TW for Kubernetes stuff: I'm happy to approve and merge this in.
I have made a bunch of edit suggestions. They're things you would have had no chance to know since this document is consistent within itself, but not up to contemporary standards. I have added context to the first instance of each type of suggestion.
Thanks for contributing!
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Dooley <[email protected]>
@ADubhlaoich, thanks for the review including the detailed explanations! I committed the suggested changes. I found the Contributing Docs only after I submitted the PR, unfortunately. Otherwise I would have learned about Hugo shortcodes and avoiding HTML spans, etc. I will also reference the style guide more before submitting my next PR. 🙂 |
…ntroller-elastic-kubernetes-services.md
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
Co-authored-by: yar <[email protected]>
Head branch was pushed to by a user without write access
...ginx/deployment-guides/amazon-web-services/ingress-controller-elastic-kubernetes-services.md
Outdated
Show resolved
Hide resolved
Co-authored-by: yar <[email protected]>
@y82, @ADubhlaoich, the note about not uploading NGINX Plus images doesn't exist as an include yet. On the I could take a stab at refactoring but I'm wondering if that should be a separate ticket since it would go beyond the scope of this one. |
@madebydna thank you, I think you're correct. IMO, you've gone "above and beyond" with your answer. Since you now have two approvals, I'm going to proceed with merge, and congratulate you on making your first contribution! |
Proposed changes
Problem: The original version of the NGINX Ingress Controller on AWS EKS guide had many outdated links, some confusing instructions, and a readability score of 9 in the Hemingway editor.
Solution: I followed the instructions on this and various linked pages to set up an open source NGINX Ingress Controller in an AWS EKS cluster. I fixed outdated links along the way. I also tried to improve the flow of the guide by reorganizing some of the instructions on the page as they relate to references on linked pages. This was necessary to avoid confusion as the guide sometimes referenced older versions of linked pages.
I also improved the wording and readability according to the Hemingway editor from a 9 to a 7 (note that I removed code snippets and file paths):
Testing: I tested the instructions several times by setting up an AWS EKS cluster with the NGINX Ingress Controller, and deploying the Cafe sample application for testing functionality.
Please focus on: One part I couldn't get to work properly was to remove the use of the PROXY Protocol as described in the Appendix. Even after I added the (necessary) step of removing the Proxy protocol setting from the AWS target groups, the client IP was still logged in the Kubernetes logs of the NGINX Ingress Controller. This is an indication that client connection information is still being forwarded from the load balancer to the proxy.
Closes #98
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
)Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.
Please refer to our style guide for guidance about placeholder content.