Skip to content

Commit 4ab7405

Browse files
salonichf5sjbermanADubhlaoich
authored
Apply suggestions from code review
Co-authored-by: Saylor Berman <[email protected]> Co-authored-by: Alan Dooley <[email protected]>
1 parent d6a1d0d commit 4ab7405

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

content/ngf/how-to/data-plane-configuration.md

+11-14
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ telemetry:
174174
175175
## Configuring the GatewayClass NginxProxy on install
176176
177-
By default, the `NginxProxy` resource is created in the same namespace where NGINX Gateway Fabric is installed. You can set configuration options in the `nginx.` Helm values, and the resource will be created and attached using the set values, when NGINX Gateway Fabric is installed using Helm. You can also manually create and attach specific `NginxProxy` resources to target different data planes [manually creating NginxProxies](#manually-creating-nginxProxies).
177+
By default, an `NginxProxy` resource is created in the same namespace where NGINX Gateway Fabric is installed, attached to the GatewayClass. You can set configuration options in the `nginx` Helm value section, and the resource will be created and attached using the set values. You can also [manually create and attach](#manually-creating-nginxProxies) specific `NginxProxy` resources to target different Gateways.
178178

179179
When installed using the Helm chart, the NginxProxy resource is named `<release-name>-proxy-config` and is created in the release Namespace.
180180

@@ -383,26 +383,23 @@ You can configure deployment and service settings for all data plane instances b
383383

384384
Users can specify these settings for NGINX data plane deployments:
385385

386-
- _replicas_ specifies the number of data plane pod replicas..
387-
- The `pod` section provides control over pod scheduling and lifecycle behavior. You can configure settings such as _terminationGracePeriodSeconds_, _tolerations_, _nodeSelector_, _affinity_, and _topologySpreadConstraints_. Use _extraVolumes_ to mount additional volumes, typically alongside container-level _extraVolumeMounts_.
388-
- The `container` defines settings for the NGINX container itself., such as resource requests and limits using _resources_, and lifecycle hooks like preStop or postStart via _lifecycle_. You can also specify _extraVolumeMounts_ to mount additional volumes defined at the pod level.
386+
- _replicas_ specifies the number of data plane pod replicas..
387+
- The `pod` section provides control over pod scheduling and lifecycle behavior. You can configure settings such as _terminationGracePeriodSeconds_, _tolerations_, _nodeSelector_, _affinity_, and _topologySpreadConstraints_. Use _extraVolumes_ to mount additional volumes, typically alongside container-level _extraVolumeMounts_.
388+
- The `container` defines settings for the NGINX container itself., such as resource requests and limits using _resources_, and lifecycle hooks like preStop or postStart via _lifecycle_. You can also specify _extraVolumeMounts_ to mount additional volumes defined at the pod level.
389389

390390
Users can specify these settings for NGINX data plane service in the `service` config:
391391

392-
- _type_ specifies the service type for the NGINX data plane. Allowed values are ClusterIP, NodePort, or LoadBalancer.
393-
- _externalTrafficPolicy_ sets how external traffic is handled. `Local` preserves the client’s source IP.
394-
- _annotations_ adds custom annotations to the NGINX data plane service.
395-
- Certain fields are only applicable when _service.type_ is set to `LoadBalancer`: _loadBalancerIP_ to assign a static IP, _loadBalancerClass_ to define the load balancer implementation, and _loadBalancerSourceRanges_ to restrict access to specific IP ranges (CIDRs).
392+
- _type_ specifies the service type for the NGINX data plane. Allowed values are ClusterIP, NodePort, or LoadBalancer.
393+
- _externalTrafficPolicy_ sets how external traffic is handled. `Local` preserves the client’s source IP.
394+
- _annotations_ adds custom annotations to the NGINX data plane service.
396395

397-
The below fields can only be specified when the `service.type` is `LoadBalancer`:
398-
- _loadBalancerIP_ specifies the static IP address of the load balancer.
399-
- _loadBalancerClass_ specifies the class of the load balancer implementation this service belongs to.
400-
- _loadBalancerSourceRanges_ specifies IP ranges (CIDR) that are allowed to access the load balancer.
396+
The below fields can only be specified when the `service.type` is `LoadBalancer`:
397+
- _loadBalancerIP_ specifies the static IP address of the load balancer.
398+
- _loadBalancerClass_ specifies the class of the load balancer implementation this service belongs to.
399+
- _loadBalancerSourceRanges_ specifies IP ranges (CIDR) that are allowed to access the load balancer.
401400

402-
---
403401

404402
## See also
405403

406404
For a full list of configuration options that can be set, see the `NginxProxy spec` in the [API reference]({{< ref "/ngf/reference/api.md" >}}).
407405

408-
---

0 commit comments

Comments
 (0)