Add template functions from sprig #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Could you give us a bit more info about what this PR does and how it fixes those three issues ? |
|
Updated the PR description with more context. |
|
I'll look into this ASAP, thanks for the PR ! |
This prevents one failed test case from aborting attempts for the other test cases, and it makes it easier to iterate on a particular test case.
Because why not.
The template name doesn't need to be globally unique.
|
I added some tests to ensure that the migration to sprig doesn't break any existing templates. |
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of useful template functions from the sprig library, which makes it easier/possible to introduce more advanced logic in templates.
Fixes #177 by adding useful functions like
append,join, andset.Fixes #293 by enabling templates to use a Go map object as a set (via the
setandhasKeyfunctions).Fixes #323 by adding a new
getHostByNamefunction.The removed functions were removed because sprig offers those same functions with the same behavior. I left functions with the same name but different behavior alone to avoid breaking existing templates.