make the pattern arg optional #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 86.05% 85.84% -0.22%
==========================================
Files 4 4
Lines 459 452 -7
==========================================
- Hits 395 388 -7
Misses 64 64 ☔ View full report in Codecov by Sentry. |
Use a tt-muncher to make the "pattern" argument optional. I tried adding support for reordering arguments, but the macro got pretty complicated and I had trouble handling the optional trailing comma. Reordering arguments would be much easier with a proc macro.
sunshowers
force-pushed
the
pattern-optional
branch
from
eada714 to
d4cb423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a tt-muncher to make the "pattern" argument optional.
I tried adding support for reordering arguments, but the macro got pretty complicated and I had trouble handling the optional trailing comma. Reordering arguments would be much easier with a proc macro.