require at least NC14 #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancborchardt
requested review from
andreasjacobsen93,
stefan-niedermann and
camilasan
jancborchardt
approved these changes
Dec 21, 2018
andreasjacobsen93
approved these changes
Dec 21, 2018
|
Hmm. Thanks for the reviews, but obviously, my plan to wait with merging this wasn't explicit enough (although I wrote "However, I will not merge this soon.") ... 😐 |
Daamn, I saw it afterwards, but assumed you meant something about #241. ;) It’s best to always put [WIP] or [Don’t merge] directly in the title if it shouldn’t be merged right away. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all that stuff that was required for Nextcloud < 14.
This is a preparation for making #241 a little bit easier. However, I will not merge this soon. But this branch will be the base for implementing #241.