Skip to content

Note renaming from within app #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claell opened this issue Jan 22, 2017 · 10 comments · Fixed by #88
Closed

Note renaming from within app #55

claell opened this issue Jan 22, 2017 · 10 comments · Fixed by #88

Comments

@claell
Copy link

claell commented Jan 22, 2017

Yesterday I installed this app and created some test notes. What was very disappointing to me is that one cannot rename a note from inside the app, but has to do it in the Notes folder. This is not very intuitive.

@korelstar
Copy link
Member

It's a key feature of this app, that filenames are derived from the first line of the note. This happens every time you change the note using this app, so the filename will change back to the content of the first line, regardless you've changed the filename in the filesystem before.

The advantage is, that you are not struggling with filenames -- you aren't even confronted with files and you can concentrate on your note. Nevertheless, this approach still produces meaningful filenames for people who want to work with the files directly.

I don't think that this behavior will be basically changed in future. However, you can always change the filename indirectly, by changing the first line of the note accordingly.

@claell
Copy link
Author

claell commented Jan 22, 2017

I already thought something like that and tried it, but it did not work for me:
bildschirmfoto vom 2017-01-22 22-15-12

@Henni
Copy link
Member

Henni commented Jan 22, 2017

@claell if that is the case we have to take a look at this.
I'm currently working on a few new test cases so I might be able to find out how this happens.

We might come back to you if we need further info.

@korelstar
Copy link
Member

korelstar commented Jan 23, 2017 via email

@claell
Copy link
Author

claell commented Jan 23, 2017

@korelstar You are right, that caused the problem.

Not very intuitive, so I hope this gets fixed soon.

@scottalanmiller
Copy link

No matter what text I put in a note, it calls itself New Note. Renaming it doesn't help, it changes itself back.

@korelstar
Copy link
Member

@scottalanmiller Please check if your text is in the first line of the note. In the screenshots I can see an empty line before the text. Please remove that line and test again.

@melissaboiko
Copy link

I wish it would ignore all empty lines (or whitespace-only lines) and name the note based on the first non-empty line.

@korelstar
Copy link
Member

This is already implemented (see #88) and will be part of the next release.

@ak1n
Copy link

ak1n commented Nov 9, 2018

The automatic renaming makes this app useless to me. I have many notes in different formats including markdown, odt, and txt. When I open once of my markdown notes to edit it they get immediately renamed to a filename I do not want the file renamed to. Otherwise this app seems like it would be very useful. Can the automatic naming be only applied to newly created files?

korelstar pushed a commit that referenced this issue Apr 24, 2020
Solution: use onSaveInstanceState to remember edited note. Because on every screen orientation change onCreate() is called which uses the original given note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants