fix: fix downloadUrl when downloading Gatsby datastore file from CDN #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-gatsby-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarahetter
approved these changes
May 31, 2022
✅ Deploy Preview for ep-optional-datastore-test ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A user trying out the new functionality in #376 found that the URL being created to download the datastore file from the CDN was incorrect as the
siteUrlwas the full URL of the request, not the domain.These changes address that issue.
Test plan
Deploy preview: https://ep-optional-datastore-test.netlify.app/
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Slack thread for the Netlifolk
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was
published correctly.