fix: support gatsby base dirs outside the site root #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for netlify-plugin-gatsby-demo ready! 🔨 Explore the source changes: 0f1173a 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/620d099efe61a5000745e653 😎 Browse the preview: https://deploy-preview-281--netlify-plugin-gatsby-demo.netlify.app |
ehmicky
reviewed
Feb 15, 2022
plugin/src/templates/handlers.ts
Outdated
| return new Promise((resolve) => { | ||
| // Create a stubbed Gatsby/Express Response object | ||
| // onResEnd is the "resolve" cb for this Promise | ||
| const res = createResponseObject({ onResEnd: resolve }) |
Contributor
There was a problem hiding this comment.
Should this line be put inside the try block? Just in case it throws.
ehmicky
previously approved these changes
Feb 15, 2022
ehmicky
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin only supports sites where the gatsby root is in a subdirectory by setting the site base to the subdirectory. This means that the site root can't be the root of a monorepo. This PR changes that, so that the root is calculated relative to the publish dir (which is hard-coded in Gatsby), ensuring that all paths are still correct.
Fixes #271