fix: gracefully handle errors when setting headers #5411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 2aa9341 Package size: 267 MB⬇️ 0.00% decrease vs. 2aa9341 Legend |
khendrikse
approved these changes
Jan 20, 2023
Contributor
khendrikse
left a comment
khendrikse
left a comment
There was a problem hiding this comment.
Very stylish and graceful 💅
danez
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we finish processing a serverless function and transfer any header it sets into the final response, we're doing a
setHeader callthat may throw. When that happens, the entire app crashes.This PR addresses that by gracefully handling the error, showing a log in the terminal and displaying the function error page.