Skip to content

Commit 48c7005

Browse files
fix: callback for onRequest
1 parent 96be73f commit 48c7005

File tree

2 files changed

+39
-2
lines changed

2 files changed

+39
-2
lines changed

src/commands/dev/dev.mjs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,15 @@ const startStaticServer = async ({ settings }) => {
6666
server.setNotFoundHandler((_req, res) => {
6767
res.sendFile('404.html', settings.dist)
6868
})
69-
server.addHook('onRequest', (req, reply) => {
69+
70+
server.addHook('onRequest', (req, reply, done) => {
7071
const validMethods = ['GET', 'HEAD']
7172
if (!validMethods.includes(req.method)) {
7273
reply.code(405).send()
73-
return reply
7474
}
75+
done()
7576
})
77+
7678
await server.listen({ port: settings.frameworkPort })
7779
log(`\n${NETLIFYDEVLOG} Static server listening to`, settings.frameworkPort)
7880
}

src/commands/dev/test-dev.js

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
import fastifyStatic from '@fastify/static'
2+
import Fastify from 'fastify'
3+
4+
const startStaticServer = async ({ settings }) => {
5+
const server = Fastify()
6+
server.register(fastifyStatic, {
7+
root: settings.dist,
8+
// eslint-disable-next-line no-unused-vars
9+
setHeaders: (res, _path, _stat) => {
10+
res.setHeader('X-Powered-by', 'netlify-dev')
11+
},
12+
})
13+
14+
server.setNotFoundHandler((_req, res) => {
15+
res.sendFile('404.html', settings.dist)
16+
})
17+
18+
server.addHook('onRequest', (req, reply, done) => {
19+
const validMethods = ['GET', 'HEAD']
20+
if (!validMethods.includes(req.method)) {
21+
reply.code(405).send()
22+
}
23+
done()
24+
})
25+
26+
await server.listen({ port: settings.frameworkPort })
27+
console.log(`Static server listening to`, settings.frameworkPort)
28+
}
29+
30+
startStaticServer({
31+
settings: {
32+
frameworkPort: '3999',
33+
dist: '/Users/kunal/Desktop/myfolder.nosync/oss/p-cli-test/static-site-no-config',
34+
},
35+
})

0 commit comments

Comments
 (0)