fix: recommend ng17 dist dir based on builder #5445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
previously approved these changes
Dec 11, 2023
|
ugh, there was a failure on windows - looks like i'll need another approval |
lukasholzer
approved these changes
Dec 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to netlify/angular-runtime#94.
In the Angular world, a
builderis something like a bundling strategy, and they decide where to output static assets. Newly created Angular applications use theapplicationbuilder, which emits static assets intodist/<project-name>/browser. Old applications that updated to NG17 can still use other builders, like thebrowserbuilder. Surprise: They output intodist/<project-name>! This PR makes us take that into account when recommending a publish directory.