Skip to content
This repository was archived by the owner on Oct 19, 2022. It is now read-only.

Bump react-hot-loader version to 4 #46

Merged
merged 1 commit into from
Jun 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react-scripts/config/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ module.exports = {
// This means they will be the "root" imports that are included in JS bundle.
// The first two entry points enable "hot" CSS and auto-refreshes for JS.
entry: [
// React Hot Loader v3
require.resolve('react-hot-loader/patch'),
// Include an alternative client for WebpackDevServer. A client's job is to
// connect to WebpackDevServer by a socket and get notified about changes.
// When you save a file, the client will either apply hot updates (in case
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"devDependencies": {
"react": "^16.0.0",
"react-dom": "^16.0.0",
"react-hot-loader": "^3.1.3",
"react-hot-loader": "^4.3.2",
"normalize.css": "^7.0.0"
},
"optionalDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/scripts/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ module.exports = function(
command = 'npm';
args = ['install', '--save', verbose && '--verbose'].filter(e => e);
}
args.push('react', 'react-dom', 'react-hot-loader@^3.1.3', 'normalize.css');
args.push('react', 'react-dom', 'react-hot-loader@^4.3.2', 'normalize.css');

// Install additional template dependencies, if present
const templateDependenciesPath = path.join(
Expand Down
21 changes: 3 additions & 18 deletions packages/react-scripts/template/src/index.js
Original file line number Diff line number Diff line change
@@ -1,28 +1,13 @@
import React from 'react';
import ReactDOM from 'react-dom';
import { AppContainer } from 'react-hot-loader';
import { hot } from 'react-hot-loader';
import 'normalize.css';

import App from 'components/App';
import registerServiceWorker from 'utils/registerServiceWorker';

function render(Component) {
ReactDOM.render(
<AppContainer>
<Component />
</AppContainer>,
document.getElementById('root'),
);
}
const HotApp = hot(module)(App);

render(App);

if (module.hot) {
module.hot.accept('./components/App', () => {
// eslint-disable-next-line global-require
const nextApp = require('./components/App').default;
render(nextApp);
});
}
ReactDOM.render(<HotApp />, document.getElementById('root'));

registerServiceWorker();