Skip to content

Fix issue with in-app browser closing on app re-entry #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

mineiwik
Copy link
Contributor

Fixes #27

@pappz pappz merged commit 5dde0f4 into netbirdio:main Nov 27, 2024
@pappz
Copy link
Contributor

pappz commented Feb 3, 2025

Hello @mineiwik

Looks like your PR caused a new issue for some users. Could you take a look to this thread?

@mineiwik
Copy link
Contributor Author

mineiwik commented Feb 3, 2025

Hi @pappz

I think the issue you referenced is more related to this issue and caused by a newer Go version which will crash on systems with Android versions below 12.

@pappz
Copy link
Contributor

pappz commented Feb 3, 2025

That you mentioned is could be a valid issue. Nevertheless, I prepared an APK without your fix and the feedback is the app does not crash. This is why I think we should look for the root cause of the issue somewhere here.

@mineiwik
Copy link
Contributor Author

mineiwik commented Feb 3, 2025

@pappz

Maybe it's worth a try to compile everything again (using Go 1.22.9) from the master branch (without changing anything) to check if the issue still persists. I don't want to say that my PR is fully correct, I just cannot find anything that could cause the issues reported.

Thanks

@pappz
Copy link
Contributor

pappz commented Feb 3, 2025

Good point! I will do.
Why did you change your answer? I mean I like to step forward to a newer version instead of back :)

@mineiwik
Copy link
Contributor Author

mineiwik commented Feb 3, 2025

@pappz

I have seen that the problem may still persist on the newer versions especially when gomobile is being used, but versions before 1.23.0 should not have this specific issue.

Sorry for not mentioning that in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-app browser closes on app re-entry
2 participants