Add support for impersonation #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optimization saving a few bytes over the wire. When there is an explicit database configured for a session, there is no need to send the impersonated user along with the `ROUTE` request. The only difference this would make is that insufficient permissions would be noticed when fetching the RT instead of when performing any actual action on the session. Since routing is part of the global driver/pool operations and not coupled to sessions, doing it this way seems like the logical conclusion.
robsdedude
force-pushed
the
impersonation
branch
from
9f3e780 to
06de216
Compare
Previously, the driver would prefer the initial router for fetching a new RT whenever the current RT had no writers (left). However, if should check what the RT looked like, when it was received.
bigmontz
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for neo4j-drivers/testkit#266 to be merged. Run TestKit tests again afterwards.