Skip to content

Send RESET when putting a connection back into the pool #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

robsdedude
Copy link
Member

Sending RESETs whenever a connection is put back into the pool makes sure there is no work outstanding on an idle connection. Unconsumed records, unacknowledged errors, or open transactions.

@robsdedude robsdedude force-pushed the reset-when-releasing-connection-into-pool branch from 0f8faa4 to d966b4a Compare May 3, 2021 14:46
@robsdedude robsdedude force-pushed the reset-when-releasing-connection-into-pool branch from d966b4a to d80ae9a Compare May 3, 2021 15:39
@robsdedude robsdedude changed the title WIP: send RESET when putting a connection back into the pool Send RESET when putting a connection back into the pool May 4, 2021
@robsdedude robsdedude requested a review from technige May 4, 2021 14:32
Copy link
Contributor

@technige technige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with comments as discussed.

@robsdedude robsdedude force-pushed the reset-when-releasing-connection-into-pool branch from 36f78e2 to f475f25 Compare May 4, 2021 15:39
@robsdedude robsdedude force-pushed the reset-when-releasing-connection-into-pool branch from f475f25 to 12ec47b Compare May 5, 2021 08:05
@robsdedude robsdedude merged commit ecb7930 into neo4j:4.3 May 5, 2021
@robsdedude
Copy link
Member Author

@robsdedude robsdedude deleted the reset-when-releasing-connection-into-pool branch July 21, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants