Skip to content

Testkit compliance #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Testkit compliance #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe993a4
Add list of skipped testkit tests
robsdedude Apr 7, 2021
c38b2d3
Testkit backend: send traceback with BackendError
robsdedude Apr 7, 2021
217545f
Decrease max_transaction_retry_time in testkit tests
robsdedude Apr 7, 2021
8e795e5
Code style
robsdedude Apr 7, 2021
9722b79
Revert "Decrease max_transaction_retry_time in testkit tests"
robsdedude Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion neo4j/io/_bolt3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
SessionExpired,
)
from neo4j.io import (
check_supported_server_product,
Bolt,
BoltPool,
check_supported_server_product,
)
from neo4j.io._common import (
CommitResponse,
Expand All @@ -62,6 +62,7 @@
Unpacker,
)


log = getLogger("neo4j")


Expand Down
1 change: 1 addition & 0 deletions neo4j/io/_bolt4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
Packer,
)


log = getLogger("neo4j")


Expand Down
1 change: 0 additions & 1 deletion neo4j/work/result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def __init__(self, connection, on_network_error):
connection raises of of the caught errors. The callback takes the
error as argument.
:type on_network_error callable

"""
self._connection = connection
self._on_network_error = on_network_error
Expand Down
8 changes: 4 additions & 4 deletions testkitbackend/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,10 @@ def _process(self, request):
if isinstance(e, Neo4jError):
payload["code"] = e.code
self.send_response("DriverError", payload)
except Exception as e:
traceback.print_exception(type(e), e, e.__traceback__)
self.send_response("BackendError",
{"msg": "%s: %s" % (type(e), e)})
except Exception:
tb = traceback.format_exc()
log.error(tb)
self.send_response("BackendError", {"msg": tb})

def send_response(self, name, data):
""" Sends a response to backend.
Expand Down
69 changes: 68 additions & 1 deletion testkitbackend/skipped_tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,68 @@
{}
{
"stub.retry.TestRetryClustering.test_retry_ForbiddenOnReadOnlyDatabase_ChangingWriter":
"Closes connection to router after ROUTE",
"stub.routing.Routing.test_should_use_resolver_during_rediscovery_when_existing_routers_fail":
"DNS resolver not implemented",
"stub.routing.RoutingV3.test_should_use_resolver_during_rediscovery_when_existing_routers_fail":
"DNS resolver not implemented",
"stub.routing.RoutingV4.test_should_use_resolver_during_rediscovery_when_existing_routers_fail":
"DNS resolver not implemented",
"stub.routing.NoRouting.test_should_use_resolver_during_rediscovery_when_existing_routers_fail":
"DNS resolver not implemented",
"stub.routing.Routing.test_should_request_rt_from_all_initial_routers_until_successful":
"DNS resolver not implemented",
"stub.routing.RoutingV3.test_should_request_rt_from_all_initial_routers_until_successful":
"DNS resolver not implemented",
"stub.routing.RoutingV4.test_should_request_rt_from_all_initial_routers_until_successful":
"DNS resolver not implemented",
"stub.routing.NoRouting.test_should_request_rt_from_all_initial_routers_until_successful":
"DNS resolver not implemented",
"stub.routing.Routing.test_should_successfully_acquire_rt_when_router_ip_changes":
"DNS resolver not implemented",
"stub.routing.RoutingV3.test_should_successfully_acquire_rt_when_router_ip_changes":
"DNS resolver not implemented",
"stub.routing.RoutingV4.test_should_successfully_acquire_rt_when_router_ip_changes":
"DNS resolver not implemented",
"stub.routing.NoRouting.test_should_successfully_acquire_rt_when_router_ip_changes":
"DNS resolver not implemented",
"stub.routing.Routing.test_should_read_successfully_on_empty_discovery_result_using_session_run":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.RoutingV3.test_should_read_successfully_on_empty_discovery_result_using_session_run":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.RoutingV4.test_should_read_successfully_on_empty_discovery_result_using_session_run":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.NoRouting.test_should_read_successfully_on_empty_discovery_result_using_session_run":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.Routing.test_should_retry_read_tx_and_rediscovery_until_success":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.RoutingV3.test_should_retry_read_tx_and_rediscovery_until_success":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.RoutingV4.test_should_retry_read_tx_and_rediscovery_until_success":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.NoRouting.test_should_retry_read_tx_and_rediscovery_until_success":
"Driver iterates over results of custom resolver and settles on first connection yielding a successful handshake",
"stub.routing.Routing.test_should_retry_write_until_success_with_leader_change_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.RoutingV3.test_should_retry_write_until_success_with_leader_change_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.RoutingV4.test_should_retry_write_until_success_with_leader_change_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.NoRouting.test_should_retry_write_until_success_with_leader_change_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.Routing.test_should_retry_write_until_success_with_leader_shutdown_during_tx_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.RoutingV3.test_should_retry_write_until_success_with_leader_shutdown_during_tx_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.RoutingV4.test_should_retry_write_until_success_with_leader_shutdown_during_tx_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.NoRouting.test_should_retry_write_until_success_with_leader_shutdown_during_tx_using_tx_function":
"Driver opens a new connection each time to get a fresh routing table",
"stub.routing.Routing.test_should_revert_to_initial_router_if_known_router_throws_protocol_errors":
"Driver uses custom resolver for each connection, not only initial seeding",
"stub.routing.RoutingV3.test_should_revert_to_initial_router_if_known_router_throws_protocol_errors":
"Driver uses custom resolver for each connection, not only initial seeding",
"stub.routing.RoutingV4.test_should_revert_to_initial_router_if_known_router_throws_protocol_errors":
"Driver uses custom resolver for each connection, not only initial seeding",
"stub.routing.NoRouting.test_should_revert_to_initial_router_if_known_router_throws_protocol_errors":
"Driver uses custom resolver for each connection, not only initial seeding"
}