Skip to content

Commit 457c1d7

Browse files
committed
Enable compilation failures on warnings for Testkit backend
1 parent 6e8c27f commit 457c1d7

34 files changed

+114
-2
lines changed

testkit-backend/pom.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,10 @@
6161
<groupId>org.apache.maven.plugins</groupId>
6262
<artifactId>maven-compiler-plugin</artifactId>
6363
<configuration>
64-
<compilerArgs combine.self="override"/>
64+
<compilerArgs combine.self="override">
65+
<arg>-Xlint:all,-processing</arg>
66+
<arg>-Werror</arg>
67+
</compilerArgs>
6568
</configuration>
6669
</plugin>
6770
<plugin>

testkit-backend/src/main/java/neo4j/org/testkit/backend/CustomDriverError.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@
1818
*/
1919
package neo4j.org.testkit.backend;
2020

21+
import java.io.Serial;
22+
2123
public class CustomDriverError extends RuntimeException {
24+
@Serial
25+
private static final long serialVersionUID = 2979071989786663535L;
26+
2227
public CustomDriverError(Throwable cause) {
2328
super(cause);
2429
}

testkit-backend/src/main/java/neo4j/org/testkit/backend/FrontendError.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,9 @@
1818
*/
1919
package neo4j.org.testkit.backend;
2020

21-
public class FrontendError extends RuntimeException {}
21+
import java.io.Serial;
22+
23+
public class FrontendError extends RuntimeException {
24+
@Serial
25+
private static final long serialVersionUID = -8369933385092563391L;
26+
}

testkit-backend/src/main/java/neo4j/org/testkit/backend/holder/RxResultHolder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.neo4j.driver.Record;
2727
import org.neo4j.driver.reactive.RxResult;
2828

29+
@SuppressWarnings("deprecation")
2930
public class RxResultHolder extends AbstractResultHolder<RxSessionHolder, RxTransactionHolder, RxResult> {
3031
@Setter
3132
private RxBufferedSubscriber<Record> subscriber;

testkit-backend/src/main/java/neo4j/org/testkit/backend/holder/RxSessionHolder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.neo4j.driver.SessionConfig;
2222
import org.neo4j.driver.reactive.RxSession;
2323

24+
@SuppressWarnings("deprecation")
2425
public class RxSessionHolder extends AbstractSessionHolder<RxSession> {
2526
public RxSessionHolder(DriverHolder driverHolder, RxSession session, SessionConfig config) {
2627
super(driverHolder, session, config);

testkit-backend/src/main/java/neo4j/org/testkit/backend/holder/RxTransactionHolder.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import org.neo4j.driver.reactive.RxTransaction;
2222

23+
@SuppressWarnings("deprecation")
2324
public class RxTransactionHolder extends AbstractTransactionHolder<RxSessionHolder, RxTransaction> {
2425
public RxTransactionHolder(RxSessionHolder sessionHolder, RxTransaction transaction) {
2526
super(sessionHolder, transaction);

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/TestkitModule.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
package neo4j.org.testkit.backend.messages;
2020

2121
import com.fasterxml.jackson.databind.module.SimpleModule;
22+
import java.io.Serial;
2223
import java.time.LocalDate;
2324
import java.util.List;
2425
import neo4j.org.testkit.backend.messages.requests.deserializer.TestkitCypherDateDeserializer;
@@ -57,6 +58,9 @@
5758
import org.neo4j.driver.types.IsoDuration;
5859

5960
public class TestkitModule extends SimpleModule {
61+
@Serial
62+
private static final long serialVersionUID = 7051732358423895087L;
63+
6064
public TestkitModule() {
6165
this.addDeserializer(List.class, new TestkitListDeserializer());
6266
this.addDeserializer(CypherDateTime.class, new TestkitCypherDateTimeDeserializer());

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/NewSession.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ private AsyncSessionHolder createAsyncSessionState(DriverHolder driverHolder, Se
105105
driverHolder, driverHolder.getDriver().asyncSession(sessionConfig), sessionConfig);
106106
}
107107

108+
@SuppressWarnings("deprecation")
108109
private RxSessionHolder createRxSessionState(DriverHolder driverHolder, SessionConfig sessionConfig) {
109110
return new RxSessionHolder(driverHolder, driverHolder.getDriver().rxSession(sessionConfig), sessionConfig);
110111
}

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionBeginTransaction.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
8888
}
8989

9090
@Override
91+
@SuppressWarnings("deprecation")
9192
public Mono<TestkitResponse> processRx(TestkitState testkitState) {
9293
return testkitState.getRxSessionHolder(data.getSessionId()).flatMap(sessionHolder -> {
9394
RxSession session = sessionHolder.getSession();

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionLastBookmarks.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
5050
}
5151

5252
@Override
53+
@SuppressWarnings("deprecation")
5354
public Mono<TestkitResponse> processRx(TestkitState testkitState) {
5455
return testkitState
5556
.getRxSessionHolder(data.getSessionId())

0 commit comments

Comments
 (0)