Add bloom updates

Author: OskarDamkjaer

src/shared/modules/auth/common.js

@@ -173,8 +173,6 @@ export const getCredentialsFromAuthResult = (result, idpId) => {
 }
 
 export const temporarlyStoreUrlSearchParams = () => {
-  const currentBrowserURLParams = getInitialisationParameters()
-
   authLog(
     `Temporarly storing the url search params. data: "${JSON.stringify(
       currentBrowserURLParams

src/shared/modules/auth/helpers.js

@@ -72,18 +72,17 @@ export const createCodeChallenge = async (method, codeVerifier) => {
 export const addSearchParamsInBrowserHistory = paramsToAddObj => {
   if (!paramsToAddObj || !isObject(paramsToAddObj)) return
 
-  const crntHashParams = window.location.hash || undefined
   const searchParams = new URLSearchParams(window.location.search)
   Object.entries(paramsToAddObj).forEach(([key, value]) => {
     if (key && value && value.length) {
       searchParams.set(key, value)
     }
   })
 
-  const newUrl = `${
-    window.location.origin
-  }?${searchParams.toString()}${crntHashParams || ''}`
-  window.history.replaceState({ path: newUrl }, '', newUrl)
+  const newUrlSearchParams = new URLSearchParams(cleansedSearchParams)
+
+  const newUrl = `${window.location.origin}?${newUrlSearchParams.toString()}`
+  window.history.replaceState({}, '', newUrl)
 }
 
 export const removeSearchParamsInBrowserHistory = paramsToRemove => {

src/shared/modules/auth/helpers.test.js

@@ -51,7 +51,7 @@ describe('addSearchParamsInBrowserHistory', () => {
     )
   })
 
-  test('keeps URL hash parameters', () => {
+  test('does not keep URL hash parameters', () => {
     const hashUrlParams = '#code=df56&code_verifier=rt43'
     window.history.replaceState(
       {},
@@ -62,9 +62,7 @@ describe('addSearchParamsInBrowserHistory', () => {
       originalWindowLocationHref + hashUrlParams
     )
     addSearchParamsInBrowserHistory({ rest: 'test' })
-    expect(window.location.href).toEqual(
-      originalWindowLocationHref + '?rest=test' + hashUrlParams
-    )
+    expect(window.location.href).toEqual('http://localhost/?code=843cvg')
   })
 })
 

src/shared/modules/auth/settings.js

@@ -21,13 +21,6 @@ export const searchParamsToRemoveAfterAuthRedirect = [
   'session_state',
   'code'
 ]
-export const searchParamsToSaveForAfterAuthRedirect = [
-  'connectURL',
-  'discoveryURL',
-  'search',
-  'perspective',
-  'run'
-]
 
 export const defaultTokenTypePrincipal = 'access_token'
 export const defaultTokenTypeAuthentication = 'access_token'