Make JS's inability to distinguish number types a feature flag (#632)

See also:
 * neo4j/neo4j-javascript-driver#1228

Author: robsdedude

nutkit/protocol/feature.py

@@ -200,6 +200,9 @@ class Feature(Enum):
     # configuration as long as values match.
     DETAIL_DEFAULT_SECURITY_CONFIG_VALUE_EQUALITY = \
         "Detail:DefaultSecurityConfigValueEquality"
+    # The driver cannot differentiate between integer and float numbers.
+    # I.e., JavaScript :P
+    DETAIL_NUMBER_IS_NUMBER = "Detail:NumberIsNumber"
 
     # === CONFIGURATION HINTS (BOLT 4.3+) ===
     # The driver understands and follow the connection hint

tests/neo4j/datatypes/test_datatypes.py

@@ -53,17 +53,29 @@ def test_should_echo_back(self):
 
         self._create_driver_and_session()
         for val in vals:
+            if self.driver_supports_features(
+                types.Feature.DETAIL_NUMBER_IS_NUMBER
+            ):
+                if (
+                    isinstance(val, types.CypherFloat)
+                    and float(val.value) % 1 == 0
+                ):
+                    continue
             # TODO: remove this block once all languages work
-            if get_driver_name() in ["javascript", "dotnet"]:
+            if get_driver_name() in ["dotnet"]:
                 # Driver treats float as int
-                if (isinstance(val, types.CypherFloat)
-                        and float(val.value) % 1 == 0):
+                if (
+                    isinstance(val, types.CypherFloat)
+                    and float(val.value) % 1 == 0
+                ):
                     continue
             # TODO: remove this block once all languages work
             if get_driver_name() in ["java", "javascript", "go", "dotnet"]:
                 # driver backend does not implement special float values
-                if (isinstance(val, types.CypherFloat)
-                        and isinstance(val.value, str)):
+                if (
+                    isinstance(val, types.CypherFloat)
+                    and isinstance(val.value, str)
+                ):
                     continue
             # TODO: remove this block once all languages work
             if get_driver_name() in ["java", "javascript", "go", "dotnet"]:

tests/neo4j/datatypes/test_spatial_types.py

@@ -34,6 +34,10 @@ def test_point_components(self):
                 ("longitude", "latitude", "height")
             ),
         ):
+            if self.driver_supports_features(
+                types.Feature.DETAIL_NUMBER_IS_NUMBER
+            ):
+                coords = tuple(c if c % 1 != 0 else c + 0.23 for c in coords)
             with self.subTest(system=system, coords=coords, names=names):
                 self._create_driver_and_session()
                 point = types.CypherPoint(system, *coords)