Skip to content

[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 2 versions ahead of your current version.

  • The recommended version was released 4 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Prototype Pollution
SNYK-JS-IMMER-1019369
452 Proof of Concept
high severity Prototype Pollution
SNYK-JS-INI-1048974
452 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864
452 Proof of Concept
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
452 Proof of Concept
high severity Improper Input Validation
SNYK-JS-URLPARSE-2407770
452 Proof of Concept
high severity Prototype Pollution
SNYK-JS-ASYNC-2441827
452 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
452 No Known Exploit
high severity Remote Memory Exposure
SNYK-JS-DNSPACKET-1293563
452 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
452 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416
452 Proof of Concept
medium severity Command Injection
SNYK-JS-REACTDEVUTILS-1083268
452 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
452 No Known Exploit
medium severity Information Exposure
SNYK-JS-EVENTSOURCE-2823375
452 Proof of Concept
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509
452 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
452 No Known Exploit
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2332181
452 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
452 Proof of Concept
medium severity Improper Input Validation
SNYK-JS-URLPARSE-1078283
452 No Known Exploit
medium severity Open Redirect
SNYK-JS-URLPARSE-1533425
452 Proof of Concept
medium severity Access Restriction Bypass
SNYK-JS-URLPARSE-2401205
452 Proof of Concept
medium severity Authorization Bypass
SNYK-JS-URLPARSE-2407759
452 Proof of Concept
medium severity Authorization Bypass Through User-Controlled Key
SNYK-JS-URLPARSE-2412697
452 Proof of Concept
low severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2396346
452 No Known Exploit
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462
452 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
452 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
452 No Known Exploit
Release notes
Package name: react-scripts
  • 4.0.3 - 2021-02-22
  • 4.0.2 - 2021-02-03
  • 4.0.1 - 2020-11-23
from react-scripts GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

See this package in npm:
react-scripts

See this project in Snyk:
https://app.snyk.io/org/newtonombese1/project/f282dae7-1fce-4d3a-9dc0-a18483e1d336?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR, automatically generated by Snyk, aims to upgrade the react-scripts dependency from version 4.0.1 to 4.0.3. The primary motivation for this upgrade is to address a significant number of reported security vulnerabilities, including several high and medium severity issues like Prototype Pollution, SSRF, ReDoS, and XSS, as detailed in the PR description. The changes are minimal, focusing solely on updating the dependency version in the package manifest.

Highlights

  • Dependency Upgrade: Upgrades the react-scripts package from version 4.0.1 to 4.0.3.
  • Security Fixes: This upgrade addresses multiple security vulnerabilities identified by Snyk, including high and medium severity issues, improving the project's security posture.

Changelog

  • package.json
    • Updated react-scripts dependency from 4.0.1 to 4.0.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A version bump so small,
Yet fixes many flaws,
Security stands tall.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, proposes an upgrade of react-scripts from version 4.0.1 to 4.0.3. This is a valuable change as it addresses a significant number of security vulnerabilities, including one critical (SNYK-JS-BABELTRAVERSE-5962462) and several high-severity issues, as detailed in the PR description. Keeping dependencies updated is crucial for security and maintainability.

Summary of Findings

  • Security Vulnerability Remediation: The upgrade of react-scripts from 4.0.1 to 4.0.3 is crucial as it addresses multiple security vulnerabilities, including the critical SNYK-JS-BABELTRAVERSE-5962462 and various high/medium severity issues.
  • Post-Upgrade Testing Recommended: Due to react-scripts being a core dependency, thorough testing of the development server, build process, and application functionality is recommended after applying this upgrade to ensure no regressions.
  • Consideration for Future react-scripts Major Version Upgrade: While this patch to react-scripts 4.0.3 is beneficial, version 4.x is relatively old. Planning a future migration to react-scripts 5.x is advised for long-term maintainability, access to newer features, and continued support.

Merge Readiness

This upgrade is important for addressing security vulnerabilities. I've raised two medium severity points for consideration:

  1. Confirmation of thorough testing after the react-scripts upgrade.
  2. A suggestion to consider and plan for a future migration to react-scripts 5.x for long-term project health.

It would be beneficial to address or acknowledge these points before merging. As an AI reviewer, I am not authorized to approve pull requests. Please ensure this change undergoes further human review and approval if necessary.

@@ -6,7 +6,7 @@
"date-fns": "^2.16.1",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since react-scripts is a critical part of the build pipeline and development server, could you please ensure that comprehensive testing is performed after this upgrade? This should ideally include:

  • Verifying the development server (npm start or yarn start) functions as expected.
  • Ensuring the production build (npm run build or yarn build) completes successfully and the output is functional.
  • Running the full automated test suite to catch any regressions.

While patch versions like this are generally safe and focused on fixes, confirming stability in your specific project is important.

@@ -6,7 +6,7 @@
"date-fns": "^2.16.1",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This upgrade to [email protected] is a positive step for security. It's also worth noting that react-scripts version 4.x is an older major version (v4.0.3 was released in February 2021, as per the release notes), with version 5.x being the latest stable release.

Has the team considered or started planning a migration to react-scripts 5.x? Upgrading would provide more up-to-date underlying tools (Webpack 5, Jest 27, etc.), potentially better performance, new features, and ensure you're on a more actively supported path. This would be a larger undertaking but is recommended for long-term project health and to stay current with the React ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants